Skip to content

[TTS][MagpieTTS] Change French tokenizer to use 'french_chartokenizer'#15205

Merged
blisc merged 1 commit intomainfrom
magpietts_opensource
Dec 18, 2025
Merged

[TTS][MagpieTTS] Change French tokenizer to use 'french_chartokenizer'#15205
blisc merged 1 commit intomainfrom
magpietts_opensource

Conversation

@subhankar-ghosh
Copy link
Collaborator

Updated French language tokenizer mapping.

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Change French tokenizer to use 'french_chartokenizer'. This update is needed because this selects the correct tokenizer for French.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Updated French language tokenizer mapping.

Signed-off-by: Subhankar Ghosh <subhankarg@nvidia.com>
@blisc blisc enabled auto-merge (squash) December 17, 2025 23:37
@github-actions github-actions bot removed the Run CICD label Dec 18, 2025
@github-actions
Copy link
Contributor

[🤖]: Hi @subhankar-ghosh 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@blisc blisc merged commit c26289a into main Dec 18, 2025
162 of 169 checks passed
@blisc blisc deleted the magpietts_opensource branch December 18, 2025 18:05
AkCodes23 pushed a commit to AkCodes23/NeMo that referenced this pull request Jan 28, 2026
)

Updated French language tokenizer mapping.

Signed-off-by: Subhankar Ghosh <subhankarg@nvidia.com>
Signed-off-by: Akhil Varanasi <akhilvaranasi23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants