Merged
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
d951d63 to
480448f
Compare
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
ananthsub
reviewed
Nov 20, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
ananthsub
approved these changes
Nov 21, 2025
Collaborator
Author
|
Failing checks are unrelated to this change. Going to merge it. |
chtruong814
added a commit
that referenced
this pull request
Nov 22, 2025
* Add deprecation notices for collections and lightning Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix warning Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix diffusion deprecation notice Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Update deprecation notice Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix nemo2 deprecation notice Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Update deprecation notice for vlm Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix multimodal_autoregressive module notice Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
chtruong814
added a commit
that referenced
this pull request
Nov 22, 2025
* Add deprecation notices for collections and lightning * Fix warning * Fix diffusion deprecation notice * Update deprecation notice * Fix nemo2 deprecation notice * Update deprecation notice for vlm * Fix multimodal_autoregressive module notice --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
quapham
pushed a commit
to quapham/NeMo
that referenced
this pull request
Dec 16, 2025
* Add deprecation notices for collections and lightning Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix warning Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix diffusion deprecation notice Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Update deprecation notice Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix nemo2 deprecation notice Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Update deprecation notice for vlm Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix multimodal_autoregressive module notice Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: quanpham <youngkwan199@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add deprecation notice to modules
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information