Skip to content

Add deprecation notice to modules#15050

Merged
chtruong814 merged 7 commits intomainfrom
chtruong/deprecate-nemo2
Nov 22, 2025
Merged

Add deprecation notice to modules#15050
chtruong814 merged 7 commits intomainfrom
chtruong/deprecate-nemo2

Conversation

@chtruong814
Copy link
Collaborator

What does this PR do ?

Add deprecation notice to modules

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 added the r2.6.0 Cherry-pick label for the r2.6.0 release branch label Nov 10, 2025
@github-actions github-actions bot added NLP Multi Modal and removed r2.6.0 Cherry-pick label for the r2.6.0 release branch labels Nov 10, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 force-pushed the chtruong/deprecate-nemo2 branch from d951d63 to 480448f Compare November 11, 2025 01:29
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
Copy link
Collaborator Author

Failing checks are unrelated to this change. Going to merge it.

@chtruong814 chtruong814 added the r2.6.0 Cherry-pick label for the r2.6.0 release branch label Nov 21, 2025
@chtruong814 chtruong814 merged commit 6389a71 into main Nov 22, 2025
202 of 206 checks passed
@chtruong814 chtruong814 deleted the chtruong/deprecate-nemo2 branch November 22, 2025 00:00
chtruong814 added a commit that referenced this pull request Nov 22, 2025
* Add deprecation notices for collections and lightning

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Fix warning

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Fix diffusion deprecation notice

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Update deprecation notice

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Fix nemo2 deprecation notice

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Update deprecation notice for vlm

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Fix multimodal_autoregressive module notice

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

---------

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
chtruong814 added a commit that referenced this pull request Nov 22, 2025
* Add deprecation notices for collections and lightning



* Fix warning



* Fix diffusion deprecation notice



* Update deprecation notice



* Fix nemo2 deprecation notice



* Update deprecation notice for vlm



* Fix multimodal_autoregressive module notice



---------

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
quapham pushed a commit to quapham/NeMo that referenced this pull request Dec 16, 2025
* Add deprecation notices for collections and lightning

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Fix warning

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Fix diffusion deprecation notice

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Update deprecation notice

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Fix nemo2 deprecation notice

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Update deprecation notice for vlm

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Fix multimodal_autoregressive module notice

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

---------

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: quanpham <youngkwan199@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Multi Modal NLP r2.6.0 Cherry-pick label for the r2.6.0 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants