chore: update Lightning requirements version#15004
Merged
Conversation
Signed-off-by: liquor233 <jiashangh@nvidia.com>
liquor233
assigned
liquor233,
chtruong814,
PytLab and
PeiyuanQi and unassigned
PytLab,
PeiyuanQi and
chtruong814
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum version requirements for three NVIDIA logger packages from 2.3.0 to 2.3.1 in the Lightning requirements file.
Key Changes
- Updated minimum version constraint for
nv_one_logger_core,nv_one_logger_training_telemetry, andnv_one_logger_pytorch_lightning_integrationfrom>=2.3.0to>=2.3.1
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
LGTM, tested with local train script to confirm 2.3.1 avoid duplicated file descriptors. |
PeiyuanQi
approved these changes
Oct 29, 2025
chtruong814
approved these changes
Oct 30, 2025
Contributor
|
[🤖]: Hi @liquor233 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
chtruong814
pushed a commit
that referenced
this pull request
Nov 10, 2025
Signed-off-by: liquor233 <jiashangh@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
chtruong814
added a commit
that referenced
this pull request
Nov 11, 2025
quapham
pushed a commit
to quapham/NeMo
that referenced
this pull request
Dec 16, 2025
Signed-off-by: liquor233 <jiashangh@nvidia.com> Signed-off-by: quanpham <youngkwan199@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information