Skip to content

Remove code related to nemo-evaluator (aka nemo-eval)#14964

Merged
athitten merged 4 commits intomainfrom
athittenn/remove_eval
Oct 23, 2025
Merged

Remove code related to nemo-evaluator (aka nemo-eval)#14964
athitten merged 4 commits intomainfrom
athittenn/remove_eval

Conversation

@athitten
Copy link
Collaborator

@athitten athitten commented Oct 21, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

  • As evaluation specific code is being placed its own repository under NVIDIA-NeMo org: https://github.com/NVIDIA-NeMo/Evaluator this PR removes all nemo-evaluation and corresponding deployment code specifically from: nemo/collections/llm/evaluation/ and nemo/collections/llm/deploy/
  • Also removes corresponding docs from: docs/source/evaluation/
  • Removes requirements/requirements_eval.txt and eval setup from setup.py
  • Removes nemo-run script for evaluation: scripts/llm/evaluation.py
  • Removes tests under tests/evaluation/ and *Eval*.sh files from tests/functional_tests/

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Abhishree <[email protected]>
pablo-garay
pablo-garay previously approved these changes Oct 21, 2025
Copy link
Collaborator

@marta-sd marta-sd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @athitten !

I think we also need to remove evaluation code from collections/llm/api, we still have imports and entrypoints for deploy and eval there.

@athitten
Copy link
Collaborator Author

Thank you @athitten !

I think we also need to remove evaluation code from collections/llm/api, we still have imports and entrypoints for deploy and eval there.

Good catch, thanks! Let me remove them

@pablo-garay
Copy link
Contributor

Thank you @athitten !
I think we also need to remove evaluation code from collections/llm/api, we still have imports and entrypoints for deploy and eval there.

Good catch, thanks! Let me remove them

Pylint failing now

Signed-off-by: Abhishree <[email protected]>
Copy link
Collaborator

@marta-sd marta-sd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@github-actions
Copy link
Contributor

[🤖]: Hi @athitten 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@athitten athitten merged commit e352140 into main Oct 23, 2025
192 checks passed
@athitten athitten deleted the athittenn/remove_eval branch October 23, 2025 20:06
pablo-garay pushed a commit that referenced this pull request Nov 10, 2025
* Remove eval code

Signed-off-by: Abhishree <[email protected]>

* Remove all evaluation tests

Signed-off-by: Abhishree <[email protected]>

* Remove eval content from api.py

Signed-off-by: Abhishree <[email protected]>

* Remove unused imports

Signed-off-by: Abhishree <[email protected]>

---------

Signed-off-by: Abhishree <[email protected]>
quapham pushed a commit to quapham/NeMo that referenced this pull request Dec 16, 2025
)

* Remove eval code

Signed-off-by: Abhishree <[email protected]>

* Remove all evaluation tests

Signed-off-by: Abhishree <[email protected]>

* Remove eval content from api.py

Signed-off-by: Abhishree <[email protected]>

* Remove unused imports

Signed-off-by: Abhishree <[email protected]>

---------

Signed-off-by: Abhishree <[email protected]>
Signed-off-by: quanpham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants