-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Force activations and weights cast to FP32 Jasper Encoder Squeeze-Excite #14715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nithinraok
previously approved these changes
Sep 11, 2025
|
@erastorgueva-nv This looks like it has an error that needs to be resolved |
Signed-off-by: Elena Rastorgueva <[email protected]>
Signed-off-by: Chen Cui <[email protected]> Co-authored-by: Chen Cui <[email protected]> Signed-off-by: Elena Rastorgueva <[email protected]>
Signed-off-by: Elena Rastorgueva <[email protected]>
70d0d10 to
ae7a7d1
Compare
chtruong814
approved these changes
Sep 15, 2025
|
[🤖]: Hi @erastorgueva-nv 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Force activations and weights cast to FP32 Jasper Encoder Squeeze-Excite
This is to fix the fact that calling
transcribe_speech.pywith a model that uses the Jasper Encoder will not work, e.g.:without the fix --> will get
RuntimeError: expected scalar type BFloat16 but found FloatCollection: ASR
Changelog
nemo/collections/asr/parts/submodules/jasper.pyforward_for_export(used whether exporting or not) check if x and self.fc are dtype float32 --> if not then cast to float32Usage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information