Skip to content

Conversation

@KunalDhawan
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

The huggingface/datasets library introduced a breaking change in release 4.0.0: the trust_remote_code parameter is no longer supported. This means dataset repositories now need to directly include the data in formats like Parquet or TSV and cannot require execution of arbitrary Python code. (Reference: release notes)

Note: cherry-pick from #14679

Currently, all datasets under mozilla-foundation are script-based, which makes them incompatible with the latest version of huggingface/datasets, even if you remove the trust_remote_code parameter.

We pin the dataset version for ASR tutorial in this PR to ensure correct behavior. We will also be working on making the datasets used be compatible with latest 'datasets' version.

Collection: ASR

Changelog

  • Changes to 2 tutorials: Multilang_ASR.ipynb and Transducers_with_HF_Datasets.ipynb

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@chtruong814 chtruong814 merged commit 3ea5a8e into r2.5.0 Sep 9, 2025
40 of 46 checks passed
@chtruong814 chtruong814 deleted the fix_hf_datasets_cherry_pick_r2.5.0 branch September 9, 2025 00:32
@github-actions github-actions bot removed the Run CICD label Sep 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

[🤖]: Hi @KunalDhawan 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants