Cherrypick calculate_per_token_loss requirement for context parallel (#14065) (#14282) into r2.4.0
#14448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add cp per token loss check Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> --------- Signed-off-by: Chen Cui <[email protected]> Signed-off-by: cuichenx <[email protected]> Co-authored-by: cuichenx <[email protected]> Signed-off-by: Charlie Truong <[email protected]>
* Add calculate_per_token_loss for CP Signed-off-by: Boxiang Wang <[email protected]> * Add check for average_in_collective Signed-off-by: Boxiang Wang <[email protected]> * Apply isort and black reformatting Signed-off-by: BoxiangW <[email protected]> * Fix CP issue by adding check on trainer.strategy.ddp_config.average_in_collective Signed-off-by: Boxiang Wang <[email protected]> * Apply isort and black reformatting Signed-off-by: BoxiangW <[email protected]> --------- Signed-off-by: Boxiang Wang <[email protected]> Signed-off-by: BoxiangW <[email protected]> Co-authored-by: BoxiangW <[email protected]> Signed-off-by: Charlie Truong <[email protected]>
Contributor
|
[🤖]: Hi @chtruong814 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
cuichenx
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Cherrypick
calculate_per_token_loss requirement for context parallel(#14065) (#14282) intor2.4.0Collection: [Note which collection this PR will affect]
Changelog
calculate_per_token_loss requirement for context parallel(Add calculate_per_token_loss support for Context Parallel #14065) (Add cp per token loss check #14282) intor2.4.0Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information