Fix LazyNeMoIterator supervision for multi-channel cuts#14409
Merged
pzelasko merged 2 commits intoNVIDIA-NeMo:mainfrom Aug 6, 2025
Merged
Fix LazyNeMoIterator supervision for multi-channel cuts#14409pzelasko merged 2 commits intoNVIDIA-NeMo:mainfrom
pzelasko merged 2 commits intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: Ante Jukić <[email protected]>
ff6d555 to
44f8ad7
Compare
Signed-off-by: anteju <[email protected]>
pzelasko
approved these changes
Aug 6, 2025
Collaborator
pzelasko
left a comment
There was a problem hiding this comment.
Great catch, thank you. LGTM
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
…14409) * Fix LazyNeMoIterator supervision for multi-channel cuts Signed-off-by: Ante Jukić <[email protected]> * Apply isort and black reformatting Signed-off-by: anteju <[email protected]> --------- Signed-off-by: Ante Jukić <[email protected]> Signed-off-by: anteju <[email protected]> Co-authored-by: anteju <[email protected]>
guyueh1
pushed a commit
to guyueh1/NeMo
that referenced
this pull request
Aug 25, 2025
…14409) * Fix LazyNeMoIterator supervision for multi-channel cuts Signed-off-by: Ante Jukić <[email protected]> * Apply isort and black reformatting Signed-off-by: anteju <[email protected]> --------- Signed-off-by: Ante Jukić <[email protected]> Signed-off-by: anteju <[email protected]> Co-authored-by: anteju <[email protected]> Signed-off-by: Guyue Huang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
This PR fixes an issue where for multichannel cuts, only the first channel was used as supervision.
Currently, processing a 2-channel audio file and using
channel_selector=1with Canary fails with the following errorThe reason for this failure is that
LazyNeMoIteratorprepared supervision without specifiyingchannel, resulting in supervision withchannel=0. Afterwards, whenwith_channelswas used to select the second channel (channel_selector=1) using_select_channel, the resulting cut had emptysupervisions. Finally, this crashed when building the Canary prompt, as shown above.Detailed description of the issue in this comment:
Collection: common
Changelog
LazyNeMoIteratorto use supervision withchannel=cut.channelUsage
This can be tested using the following scripts
Test using
The following examples will raise an error:
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information