Skip to content

Conversation

@youngeunkwon0405
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Fix the issue reported in #14392

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Youngeun Kwon <[email protected]>
@youngeunkwon0405 youngeunkwon0405 requested a review from ko3n1g August 4, 2025 21:01
@youngeunkwon0405 youngeunkwon0405 self-assigned this Aug 4, 2025
@youngeunkwon0405
Copy link
Collaborator Author

This is a script-only change. So I guess it is okay to skip CICD.

@youngeunkwon0405 youngeunkwon0405 requested a review from yfw August 4, 2025 21:15
@ko3n1g ko3n1g requested a review from chtruong814 August 4, 2025 21:27
@ko3n1g ko3n1g added the Run CICD label Aug 4, 2025
@ko3n1g ko3n1g merged commit b9c740f into NVIDIA-NeMo:r2.4.0 Aug 4, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants