Skip to content

fix: reduce the excessive test time of test_msdd_diar_inference #14366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablo-garay merged 8 commits into from
Aug 1, 2025
Merged

fix: reduce the excessive test time of test_msdd_diar_inference #14366

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
02daa1d
Reduced the test time by 4 fold removing redundant testing
tango4j Jul 30, 2025
22dad96
Activated CPU test
tango4j Jul 30, 2025
42a479d
Add CPU and CUDA tests. remmoved print function
tango4j Jul 30, 2025
6d901c0
Merge branch 'main' into fix_msdd_unit_test
tango4j Jul 30, 2025
577dd9b
Skipping this test since timeout issue is not solved
tango4j Jul 31, 2025
b1f2506
Merge branch 'fix_msdd_unit_test' of https://github.com/tango4j/NeMo …
tango4j Jul 31, 2025
d2c3c16
Merge branch 'main' into fix_msdd_unit_test
tango4j Jul 31, 2025
f746fac
Apply isort and black reformatting
tango4j Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions tests/collections/speaker_tasks/test_diar_neural_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,11 @@

class TestNeuralDiarizerInference:
@pytest.mark.unit
@pytest.mark.parametrize(
"device",
[
torch.device("cpu"),
pytest.param(
torch.device("cuda"),
marks=pytest.mark.skipif(
not torch.cuda.is_available(),
reason='CUDA required for test.',
),
),
],
@pytest.mark.skip(
reason="Unknown timeout issue: This function takes too long to run when it is run with the other tests."
)
@pytest.mark.pleasefixme
@pytest.mark.parametrize("num_speakers", [None, 1])
@pytest.mark.parametrize("device", [torch.device("cpu"), torch.device("cuda")])
@pytest.mark.parametrize("num_speakers", [None])
@pytest.mark.parametrize("max_num_speakers", [4])
def test_msdd_diar_inference(self, tmpdir, test_data_dir, device, num_speakers, max_num_speakers):
"""
Expand All @@ -47,13 +37,12 @@ def test_msdd_diar_inference(self, tmpdir, test_data_dir, device, num_speakers,
- Ensures temporary directory is emptied at the end of diarization
- Sanity check to ensure outputs from diarization are reasonable
"""
audio_filenames = ['an22-flrp-b.wav', 'an90-fbbh-b.wav']
audio_filenames = ['an90-fbbh-b.wav']
audio_paths = [os.path.join(test_data_dir, "asr", "train", "an4", "wav", fp) for fp in audio_filenames]

diarizer = NeuralDiarizer.from_pretrained(model_name='diar_msdd_telephonic').to(device)

out_dir = os.path.join(tmpdir, 'diarize_inference/')

assert diarizer.msdd_model.device.type == device.type
assert diarizer._speaker_model.device.type == device.type
for audio_path in audio_paths:
Expand Down
Loading