Skip to content

[MoE] Partial Cudagraph support for MoE#14362

Merged
gdengk merged 8 commits intoNVIDIA-NeMo:mainfrom
gdengk:gaod/moe/partial_cg_support
Aug 4, 2025
Merged

[MoE] Partial Cudagraph support for MoE#14362
gdengk merged 8 commits intoNVIDIA-NeMo:mainfrom
gdengk:gaod/moe/partial_cg_support

Conversation

@gdengk
Copy link
Collaborator

@gdengk gdengk commented Jul 30, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Support partial cudagraph capture through external cudagraph.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@gdengk gdengk force-pushed the gaod/moe/partial_cg_support branch from f0da450 to 4ac8fa5 Compare August 1, 2025 07:04
gdengk added 2 commits August 1, 2025 00:05
Signed-off-by: gdeng <[email protected]>
@gdengk gdengk force-pushed the gaod/moe/partial_cg_support branch from 4ac8fa5 to 4c4d386 Compare August 1, 2025 07:05
@gdengk gdengk requested review from cuichenx and erhoo82 August 1, 2025 18:41
@gdengk gdengk marked this pull request as ready for review August 1, 2025 21:38
cuichenx
cuichenx previously approved these changes Aug 1, 2025
Copy link
Collaborator

@cuichenx cuichenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from FW side

Signed-off-by: gdeng <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Aug 4, 2025
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Aug 4, 2025
@gdengk gdengk enabled auto-merge (squash) August 4, 2025 05:05
Copy link
Collaborator

@cuichenx cuichenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdengk gdengk merged commit 7d361dc into NVIDIA-NeMo:main Aug 4, 2025
282 checks passed
@gdengk gdengk deleted the gaod/moe/partial_cg_support branch August 4, 2025 21:38
@gdengk gdengk restored the gaod/moe/partial_cg_support branch August 4, 2025 23:50
chtruong814 added a commit that referenced this pull request Aug 4, 2025
chtruong814 added a commit that referenced this pull request Aug 5, 2025
This reverts commit 7d361dc.

Signed-off-by: Charlie Truong <[email protected]>
chtruong814 added a commit that referenced this pull request Aug 5, 2025
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
* local experimental setup

Signed-off-by: gdeng <[email protected]>

* local working version

Signed-off-by: gdeng <[email protected]>

* cleanup

Signed-off-by: gdeng <[email protected]>

* Apply isort and black reformatting

Signed-off-by: gdengk <[email protected]>

* fix the issue

Signed-off-by: gdeng <[email protected]>

* Apply isort and black reformatting

Signed-off-by: gdengk <[email protected]>

---------

Signed-off-by: gdeng <[email protected]>
Signed-off-by: gdengk <[email protected]>
Co-authored-by: gdengk <[email protected]>
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
guyueh1 pushed a commit to guyueh1/NeMo that referenced this pull request Aug 25, 2025
* local experimental setup

Signed-off-by: gdeng <[email protected]>

* local working version

Signed-off-by: gdeng <[email protected]>

* cleanup

Signed-off-by: gdeng <[email protected]>

* Apply isort and black reformatting

Signed-off-by: gdengk <[email protected]>

* fix the issue

Signed-off-by: gdeng <[email protected]>

* Apply isort and black reformatting

Signed-off-by: gdengk <[email protected]>

---------

Signed-off-by: gdeng <[email protected]>
Signed-off-by: gdengk <[email protected]>
Co-authored-by: gdengk <[email protected]>
Signed-off-by: Guyue Huang <[email protected]>
guyueh1 pushed a commit to guyueh1/NeMo that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants