-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add deprecation notice to eval code #14316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b2334b7
Add deprecation notice to eval code
athitten bf8956a
Update nemo/collections/llm/api.py
ko3n1g fe1f46d
Update nemo/collections/llm/api.py
ko3n1g 0cc0c36
Update scripts/llm/evaluation.py
ko3n1g 49dcc56
Update scripts/llm/evaluation.py
ko3n1g 4314087
deprecate export-deploy as well
ko3n1g da12596
Apply isort and black reformatting
ko3n1g abfb28d
f
ko3n1g ea19290
Apply isort and black reformatting
ko3n1g 56b4aa3
Merge remote-tracking branch 'origin/main' into athitten/eval_depreca…
ko3n1g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,11 +12,22 @@ | |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import warnings | ||
|
|
||
| warnings.warn( | ||
| "This evaluation script is deprecated and will be removed in NeMo FW 25.09 container release. " | ||
| "For evaluation functionality, please use the new Eval repository: https://github.com/NVIDIA/NeMo-Eval", | ||
|
||
| DeprecationWarning, | ||
| stacklevel=1, | ||
| ) | ||
|
|
||
| # NOTE: This script is only an example of using NeMo with NeMo-Run's APIs and is subject to change without notice. | ||
| # This script is used for evaluation on local and slurm executors using NeMo-Run. | ||
| # It uses deploy method from nemo/llm/collections/api.py to deploy nemo2.0 ckpt on PyTriton server and uses evaluate | ||
| # method from nemo/llm/collections/api.py to run evaluation on it. | ||
| # (https://github.com/NVIDIA/NeMo-Run) to configure and execute the runs. | ||
| # DEPRECATED: This script and the underlying deploy/evaluate functions will be removed in NeMo FW 25.09. | ||
| # Please use the new Eval repository: https://github.com/NVIDIA/NeMo-Eval | ||
ko3n1g marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| import argparse | ||
| from typing import Optional | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here:
https://github.com/NVIDIA-NeMo/Eval