-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Moving export security fixes over here #14254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Onur Yilmaz <[email protected]>
Signed-off-by: oyilmaz-nvidia <[email protected]>
Signed-off-by: Onur Yilmaz <[email protected]>
…into onur/export-sec-vul
chtruong814
previously approved these changes
Jul 16, 2025
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Contributor
|
[🤖]: Hi @oyilmaz-nvidia 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
ko3n1g
approved these changes
Jul 17, 2025
chtruong814
added a commit
that referenced
this pull request
Jul 17, 2025
* Moving security fixes over here Signed-off-by: Onur Yilmaz <[email protected]> * Apply isort and black reformatting Signed-off-by: oyilmaz-nvidia <[email protected]> * Removing another line Signed-off-by: Onur Yilmaz <[email protected]> * Remove unpack_tarball from tensorrt llm export Signed-off-by: Charlie Truong <[email protected]> * Set export deploy gpu unit tests as optional Signed-off-by: Charlie Truong <[email protected]> * Fix setting gpu export unit tests as optional Signed-off-by: Charlie Truong <[email protected]> --------- Signed-off-by: Onur Yilmaz <[email protected]> Signed-off-by: oyilmaz-nvidia <[email protected]> Signed-off-by: Charlie Truong <[email protected]> Co-authored-by: oyilmaz-nvidia <[email protected]> Co-authored-by: Charlie Truong <[email protected]>
ko3n1g
pushed a commit
that referenced
this pull request
Jul 17, 2025
* Moving security fixes over here * Apply isort and black reformatting * Removing another line * Remove unpack_tarball from tensorrt llm export * Set export deploy gpu unit tests as optional * Fix setting gpu export unit tests as optional --------- Signed-off-by: Onur Yilmaz <[email protected]> Signed-off-by: oyilmaz-nvidia <[email protected]> Signed-off-by: Charlie Truong <[email protected]> Co-authored-by: Onur Yilmaz <[email protected]> Co-authored-by: oyilmaz-nvidia <[email protected]>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Jul 23, 2025
* Moving security fixes over here Signed-off-by: Onur Yilmaz <[email protected]> * Apply isort and black reformatting Signed-off-by: oyilmaz-nvidia <[email protected]> * Removing another line Signed-off-by: Onur Yilmaz <[email protected]> * Remove unpack_tarball from tensorrt llm export Signed-off-by: Charlie Truong <[email protected]> * Set export deploy gpu unit tests as optional Signed-off-by: Charlie Truong <[email protected]> * Fix setting gpu export unit tests as optional Signed-off-by: Charlie Truong <[email protected]> --------- Signed-off-by: Onur Yilmaz <[email protected]> Signed-off-by: oyilmaz-nvidia <[email protected]> Signed-off-by: Charlie Truong <[email protected]> Co-authored-by: oyilmaz-nvidia <[email protected]> Co-authored-by: Charlie Truong <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Aug 4, 2025
* Moving security fixes over here Signed-off-by: Onur Yilmaz <[email protected]> * Apply isort and black reformatting Signed-off-by: oyilmaz-nvidia <[email protected]> * Removing another line Signed-off-by: Onur Yilmaz <[email protected]> * Remove unpack_tarball from tensorrt llm export Signed-off-by: Charlie Truong <[email protected]> * Set export deploy gpu unit tests as optional Signed-off-by: Charlie Truong <[email protected]> * Fix setting gpu export unit tests as optional Signed-off-by: Charlie Truong <[email protected]> --------- Signed-off-by: Onur Yilmaz <[email protected]> Signed-off-by: oyilmaz-nvidia <[email protected]> Signed-off-by: Charlie Truong <[email protected]> Co-authored-by: oyilmaz-nvidia <[email protected]> Co-authored-by: Charlie Truong <[email protected]>
chtruong814
added a commit
that referenced
this pull request
Aug 7, 2025
* Moving security fixes over here * Apply isort and black reformatting * Removing another line * Remove unpack_tarball from tensorrt llm export * Set export deploy gpu unit tests as optional * Fix setting gpu export unit tests as optional --------- Signed-off-by: Onur Yilmaz <[email protected]> Signed-off-by: oyilmaz-nvidia <[email protected]> Signed-off-by: Charlie Truong <[email protected]> Co-authored-by: Onur Yilmaz <[email protected]> Co-authored-by: oyilmaz-nvidia <[email protected]> Signed-off-by: Charlie Truong <[email protected]>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
* Moving security fixes over here Signed-off-by: Onur Yilmaz <[email protected]> * Apply isort and black reformatting Signed-off-by: oyilmaz-nvidia <[email protected]> * Removing another line Signed-off-by: Onur Yilmaz <[email protected]> * Remove unpack_tarball from tensorrt llm export Signed-off-by: Charlie Truong <[email protected]> * Set export deploy gpu unit tests as optional Signed-off-by: Charlie Truong <[email protected]> * Fix setting gpu export unit tests as optional Signed-off-by: Charlie Truong <[email protected]> --------- Signed-off-by: Onur Yilmaz <[email protected]> Signed-off-by: oyilmaz-nvidia <[email protected]> Signed-off-by: Charlie Truong <[email protected]> Co-authored-by: oyilmaz-nvidia <[email protected]> Co-authored-by: Charlie Truong <[email protected]>
chtruong814
added a commit
that referenced
this pull request
Aug 10, 2025
* Moving security fixes over here * Apply isort and black reformatting * Removing another line * Remove unpack_tarball from tensorrt llm export * Set export deploy gpu unit tests as optional * Fix setting gpu export unit tests as optional --------- Signed-off-by: Onur Yilmaz <[email protected]> Signed-off-by: oyilmaz-nvidia <[email protected]> Signed-off-by: Charlie Truong <[email protected]> Co-authored-by: Onur Yilmaz <[email protected]> Co-authored-by: oyilmaz-nvidia <[email protected]>
guyueh1
pushed a commit
to guyueh1/NeMo
that referenced
this pull request
Aug 25, 2025
* Moving security fixes over here Signed-off-by: Onur Yilmaz <[email protected]> * Apply isort and black reformatting Signed-off-by: oyilmaz-nvidia <[email protected]> * Removing another line Signed-off-by: Onur Yilmaz <[email protected]> * Remove unpack_tarball from tensorrt llm export Signed-off-by: Charlie Truong <[email protected]> * Set export deploy gpu unit tests as optional Signed-off-by: Charlie Truong <[email protected]> * Fix setting gpu export unit tests as optional Signed-off-by: Charlie Truong <[email protected]> --------- Signed-off-by: Onur Yilmaz <[email protected]> Signed-off-by: oyilmaz-nvidia <[email protected]> Signed-off-by: Charlie Truong <[email protected]> Co-authored-by: oyilmaz-nvidia <[email protected]> Co-authored-by: Charlie Truong <[email protected]> Signed-off-by: Guyue Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Moves some of the fixes in export deploy to this repo.