Skip to content

fix eval_beamsearch_ngram_ctc script#14238

Merged
nithinraok merged 16 commits intomainfrom
lgrigoryan/fix-eval_beamsearch_ngram_ctc
Jul 15, 2025
Merged

fix eval_beamsearch_ngram_ctc script#14238
nithinraok merged 16 commits intomainfrom
lgrigoryan/fix-eval_beamsearch_ngram_ctc

Conversation

@lilithgrigoryan
Copy link
Collaborator

@lilithgrigoryan lilithgrigoryan commented Jul 15, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Fix of eval_beamsearch_ngram_ctc script mentioned here #13064.

Collection: ASR

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

lilithgrigoryan and others added 13 commits May 2, 2025 00:22
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
@lilithgrigoryan lilithgrigoryan force-pushed the lgrigoryan/fix-eval_beamsearch_ngram_ctc branch from 02f4e12 to b834bc9 Compare July 15, 2025 11:43
@lilithgrigoryan lilithgrigoryan force-pushed the lgrigoryan/fix-eval_beamsearch_ngram_ctc branch from ebbd828 to f2133d8 Compare July 15, 2025 11:59
Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
@lilithgrigoryan lilithgrigoryan changed the title Lgrigoryan/fix eval beamsearch ngram ctc fix eval_beamsearch_ngram_ctc script Jul 15, 2025
@lilithgrigoryan lilithgrigoryan marked this pull request as ready for review July 15, 2025 12:28
@github-actions github-actions bot removed the Run CICD label Jul 15, 2025
@github-actions
Copy link
Contributor

[🤖]: Hi @lilithgrigoryan 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

Copy link
Member

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nithinraok nithinraok merged commit 1428996 into main Jul 15, 2025
55 checks passed
@nithinraok nithinraok deleted the lgrigoryan/fix-eval_beamsearch_ngram_ctc branch July 15, 2025 16:09
lilithgrigoryan added a commit that referenced this pull request Jul 15, 2025
* add fix

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* refactor

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* fix

Signed-off-by: lilithgrigoryan <[email protected]>

* clean up

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

---------

Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Co-authored-by: lilithgrigoryan <[email protected]>
Co-authored-by: oliver könig <[email protected]>
nithinraok pushed a commit that referenced this pull request Jul 15, 2025
* add fix



* minor fix



* Apply isort and black reformatting



* refactor



* minor fix



* Apply isort and black reformatting



* minor fix



* fix



* clean up



* restore gitignore



* restore gitignore



---------

Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Co-authored-by: lilithgrigoryan <[email protected]>
Co-authored-by: oliver könig <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Jul 23, 2025
* add fix

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* refactor

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* fix

Signed-off-by: lilithgrigoryan <[email protected]>

* clean up

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

---------

Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Co-authored-by: lilithgrigoryan <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Aug 4, 2025
* add fix

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* refactor

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* fix

Signed-off-by: lilithgrigoryan <[email protected]>

* clean up

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

---------

Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Co-authored-by: lilithgrigoryan <[email protected]>
Co-authored-by: oliver könig <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
* add fix

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* refactor

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* fix

Signed-off-by: lilithgrigoryan <[email protected]>

* clean up

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

---------

Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Co-authored-by: lilithgrigoryan <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
* add fix

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* refactor

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* fix

Signed-off-by: lilithgrigoryan <[email protected]>

* clean up

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

---------

Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Co-authored-by: lilithgrigoryan <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
* add fix

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* refactor

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* fix

Signed-off-by: lilithgrigoryan <[email protected]>

* clean up

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

---------

Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Co-authored-by: lilithgrigoryan <[email protected]>
Co-authored-by: oliver könig <[email protected]>
guyueh1 pushed a commit to guyueh1/NeMo that referenced this pull request Aug 25, 2025
* add fix

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* refactor

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* Apply isort and black reformatting

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

* fix

Signed-off-by: lilithgrigoryan <[email protected]>

* clean up

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

* restore gitignore

Signed-off-by: lilithgrigoryan <[email protected]>

---------

Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: lilithgrigoryan <[email protected]>
Co-authored-by: lilithgrigoryan <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Guyue Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants