Allow exception in hf ckpt load attempt before fallback to standard l… #14214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jenchen13
approved these changes
Jul 14, 2025
|
@ericharper @ko3n1g can you help me understand the codecov issue? |
maanug-nv
approved these changes
Jul 16, 2025
…oad strategy Signed-off-by: Timur Rvachov <[email protected]>
Signed-off-by: Timur Rvachov <[email protected]>
maanug-nv
force-pushed
the
trvachov/cpkt_load_fix
branch
from
f18ccbd to
20f7296
Compare
9 tasks
github-merge-queue bot
pushed a commit
to NVIDIA/bionemo-framework
that referenced
this pull request
Jul 18, 2025
### Description Point NeMo back to `main` branch after PR that fixes bionemo checkpoint load has been merged (NVIDIA-NeMo/NeMo#14214) ### Type of changes <!-- Mark the relevant option with an [x] --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Refactor - [ ] Documentation update - [ ] Other (please describe): ### CI Pipeline Configuration Configure CI behavior by applying the relevant labels: - [SKIP_CI](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#skip_ci) - Skip all continuous integration tests - [INCLUDE_NOTEBOOKS_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_notebooks_tests) - Execute notebook validation tests in pytest - [INCLUDE_SLOW_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_slow_tests) - Execute tests labelled as slow in pytest for extensive testing > [!NOTE] > By default, the notebooks validation tests are skipped unless explicitly enabled. #### Authorizing CI Runs We use [copy-pr-bot](https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/#automation) to manage authorization of CI runs on NVIDIA's compute resources. * If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123) * If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an `/ok to test` comment on the pull request to trigger CI. This will need to be done for each new commit. ### Usage <!--- How does a user interact with the changed code --> ```python TODO: Add code snippet ``` ### Pre-submit Checklist <!--- Ensure all items are completed before submitting --> - [ ] I have tested these changes locally - [ ] I have updated the documentation accordingly - [ ] I have added/updated tests as needed - [ ] All existing tests pass successfully Signed-off-by: Timur Rvachov <[email protected]>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Jul 23, 2025
NVIDIA-NeMo#14214) * Allow exception in hf ckpt load attempt before fallback to standard load strategy Signed-off-by: Timur Rvachov <[email protected]> * Make exception RuntimeError specific Signed-off-by: Timur Rvachov <[email protected]> --------- Signed-off-by: Timur Rvachov <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Aug 4, 2025
#14214) * Allow exception in hf ckpt load attempt before fallback to standard load strategy Signed-off-by: Timur Rvachov <[email protected]> * Make exception RuntimeError specific Signed-off-by: Timur Rvachov <[email protected]> --------- Signed-off-by: Timur Rvachov <[email protected]>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
NVIDIA-NeMo#14214) * Allow exception in hf ckpt load attempt before fallback to standard load strategy Signed-off-by: Timur Rvachov <[email protected]> * Make exception RuntimeError specific Signed-off-by: Timur Rvachov <[email protected]> --------- Signed-off-by: Timur Rvachov <[email protected]>
guyueh1
pushed a commit
to guyueh1/NeMo
that referenced
this pull request
Aug 25, 2025
NVIDIA-NeMo#14214) * Allow exception in hf ckpt load attempt before fallback to standard load strategy Signed-off-by: Timur Rvachov <[email protected]> * Make exception RuntimeError specific Signed-off-by: Timur Rvachov <[email protected]> --------- Signed-off-by: Timur Rvachov <[email protected]> Signed-off-by: Guyue Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
The current
export_ckptcode contains logic that attempts some kind of ModelOpt checkpoint load, and if it fails, then defaults to the usual checkpoint load. The current code assumes that if the ModelOpt checkpoint load fails, aNoneoutputwill be the result, but that isn't always the case -- sometimes it fails by throwing an exception. In this case, I just added a try catch block to deal with this.This solution is not ideal, but and this PR is just to get the discussion started and also to unblock BioNeMo which is currently stuck on this.
Collection: All
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information