Skip to content

Conversation

@chtruong814
Copy link
Collaborator

This reverts commit e04ee42.

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Revert "Safely import optional python packages (#13936)"

This was able to merge without the CI running. And it seems some failures are happening on subsequent tests:
https://github.com/NVIDIA/NeMo/actions/runs/16218093086/job/45792718838

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

This reverts commit e04ee42.

Signed-off-by: Charlie Truong <[email protected]>
@chtruong814
Copy link
Collaborator Author

Verified that this fixes the failing test after manually running this on a CI machine. Moving forward with the revert to unblock other PRs. I think I know the issue and will open a new PR with a fix.

@chtruong814 chtruong814 merged commit 808845b into main Jul 11, 2025
36 checks passed
@chtruong814 chtruong814 deleted the chtruong/revert-safeimport branch July 11, 2025 12:17
chtruong814 added a commit that referenced this pull request Jul 11, 2025
chtruong814 added a commit that referenced this pull request Jul 11, 2025
* Revert "Revert "Safely import optional python packages (#13936)" (#14197)"

This reverts commit 808845b.

Signed-off-by: Charlie Truong <[email protected]>

* Fix LocalCheckpointCallback safe import

Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: Charlie Truong <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Jul 23, 2025
…VIDIA-NeMo#14197)

This reverts commit e04ee42.

Signed-off-by: Charlie Truong <[email protected]>
Co-authored-by: Robert Clark <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Jul 23, 2025
…DIA-NeMo#14198)

* Revert "Revert "Safely import optional python packages (NVIDIA-NeMo#13936)" (NVIDIA-NeMo#14197)"

This reverts commit 808845b.

Signed-off-by: Charlie Truong <[email protected]>

* Fix LocalCheckpointCallback safe import

Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Aug 4, 2025
This reverts commit e04ee42.

Signed-off-by: Charlie Truong <[email protected]>
Co-authored-by: Robert Clark <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Aug 4, 2025
* Revert "Revert "Safely import optional python packages (#13936)" (#14197)"

This reverts commit 808845b.

Signed-off-by: Charlie Truong <[email protected]>

* Fix LocalCheckpointCallback safe import

Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: Charlie Truong <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
…VIDIA-NeMo#14197)

This reverts commit e04ee42.

Signed-off-by: Charlie Truong <[email protected]>
Co-authored-by: Robert Clark <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
…DIA-NeMo#14198)

* Revert "Revert "Safely import optional python packages (NVIDIA-NeMo#13936)" (NVIDIA-NeMo#14197)"

This reverts commit 808845b.

Signed-off-by: Charlie Truong <[email protected]>

* Fix LocalCheckpointCallback safe import

Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
…VIDIA-NeMo#14197)

This reverts commit e04ee42.

Signed-off-by: Charlie Truong <[email protected]>
Co-authored-by: Robert Clark <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
…DIA-NeMo#14198)

* Revert "Revert "Safely import optional python packages (NVIDIA-NeMo#13936)" (NVIDIA-NeMo#14197)"

This reverts commit 808845b.

Signed-off-by: Charlie Truong <[email protected]>

* Fix LocalCheckpointCallback safe import

Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
…DIA-NeMo#14198)

* Revert "Revert "Safely import optional python packages (NVIDIA-NeMo#13936)" (NVIDIA-NeMo#14197)"

This reverts commit 808845b.

Signed-off-by: Charlie Truong <[email protected]>

* Fix LocalCheckpointCallback safe import

Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: Charlie Truong <[email protected]>
guyueh1 pushed a commit to guyueh1/NeMo that referenced this pull request Aug 25, 2025
…VIDIA-NeMo#14197)

This reverts commit e04ee42.

Signed-off-by: Charlie Truong <[email protected]>
Co-authored-by: Robert Clark <[email protected]>
Signed-off-by: Guyue Huang <[email protected]>
guyueh1 pushed a commit to guyueh1/NeMo that referenced this pull request Aug 25, 2025
…DIA-NeMo#14198)

* Revert "Revert "Safely import optional python packages (NVIDIA-NeMo#13936)" (NVIDIA-NeMo#14197)"

This reverts commit 808845b.

Signed-off-by: Charlie Truong <[email protected]>

* Fix LocalCheckpointCallback safe import

Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Guyue Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants