Conversation
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
…om/NVIDIA/NeMo into dpykhtar/remove_language_modelling
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
| from nemo.collections.nlp.data.language_modeling.megatron.gpt_sft_chat_dataset import ( | ||
| _get_header_conversation_type_mask_role, | ||
| get_prompt_template_example, | ||
| ) |
Check notice
Code scanning / CodeQL
Unused import Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 8 months ago
To fix the problem:
- Remove the unused import
get_prompt_template_examplefrom thenemo.collections.nlp.data.language_modeling.megatron.gpt_sft_chat_datasetmodule. - Ensure that the removal does not affect the functionality of the code, as no references to
get_prompt_template_exampleexist in the file.
Detailed steps:
- Locate the import statement starting on line 29.
- Remove the specific
get_prompt_template_examplefrom the import list while keeping any other imports intact (_get_header_conversation_type_mask_role).
| @@ -28,7 +28,6 @@ | ||
| try: | ||
| from nemo.collections.nlp.data.language_modeling.megatron.gpt_sft_chat_dataset import ( | ||
| _get_header_conversation_type_mask_role, | ||
| get_prompt_template_example, | ||
| ) | ||
|
|
||
| HAVE_NLP = True |
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
chtruong814
left a comment
There was a problem hiding this comment.
@dimapihtar this is all nemo1 code we're removing?
|
@dimapihtar I think that last test is failing because the path for helpers.cpp file was renamed. |
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
no, we have nemo.nlp.modules left which will be removed in the next separate PR. It's just complicated to remove everything in a single PR. |
It was failing because I forgot to move Makefile in addition to helpers.cpp |
|
[🤖]: Hi @dimapihtar 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Removes nlp/language_modelling.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information