Skip to content

Conversation

@lilithgrigoryan
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: lilithgrigoryan <[email protected]>
@github-actions github-actions bot added the ASR label Jul 1, 2025
@lilithgrigoryan lilithgrigoryan changed the title add docs for asr NGPU-LM customization add/refactor docs for asr lm customization Jul 1, 2025
Signed-off-by: lilithgrigoryan <[email protected]>
Copy link
Collaborator

@artbataev artbataev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

[🤖]: Hi @lilithgrigoryan 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@lilithgrigoryan lilithgrigoryan merged commit 6cadb8e into main Jul 1, 2025
53 checks passed
@lilithgrigoryan lilithgrigoryan deleted the lgrigoryan/ngpu_lm_beam_search_docs branch July 1, 2025 20:18
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Jul 23, 2025
* add docs

Signed-off-by: lilithgrigoryan <[email protected]>

* refactor asr customization and lm docs

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

---------

Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
* add docs

Signed-off-by: lilithgrigoryan <[email protected]>

* refactor asr customization and lm docs

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

---------

Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
* add docs

Signed-off-by: lilithgrigoryan <[email protected]>

* refactor asr customization and lm docs

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

---------

Signed-off-by: lilithgrigoryan <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
* add docs

Signed-off-by: lilithgrigoryan <[email protected]>

* refactor asr customization and lm docs

Signed-off-by: lilithgrigoryan <[email protected]>

* minor fix

Signed-off-by: lilithgrigoryan <[email protected]>

---------

Signed-off-by: lilithgrigoryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants