Change to enable full iteration CUDA graph for LLMs#14077
Merged
erhoo82 merged 18 commits intoNVIDIA-NeMo:mainfrom Aug 16, 2025
Merged
Change to enable full iteration CUDA graph for LLMs#14077erhoo82 merged 18 commits intoNVIDIA-NeMo:mainfrom
erhoo82 merged 18 commits intoNVIDIA-NeMo:mainfrom
Conversation
d12fabd to
d7364e5
Compare
0c1a110 to
b11fd52
Compare
04e60ed to
71f2c6b
Compare
katec846
reviewed
Jul 31, 2025
Contributor
katec846
left a comment
There was a problem hiding this comment.
I’m not entirely sure what the final PR solution should look like, but for cases where pipeline parallelism is greater than 1, we currently have two options:
- Remove the sync() call in p2p_communication.py though we would need to justify that it's safe to remove it.
- Add assertions to ensure that
config.batch_p2p_sync == Falseandconfig.variable_seq_lengths ==False
Also, for cases where VP > 1, we need to disable optim.overlap_param_gather on H100 to make it able to run.
erhoo82
reviewed
Aug 1, 2025
e76759d to
916d50d
Compare
916d50d to
8d85e0b
Compare
19ba6a2 to
027c7c7
Compare
vasunvidia
commented
Aug 14, 2025
erhoo82
previously approved these changes
Aug 14, 2025
Initial commit Signed-off-by: Vasudevan Rengasamy <[email protected]> Rename FullCGWrapper to FullCudaGraphWrapper Signed-off-by: Vasudevan Rengasamy <[email protected]> Change full_cuda_graph to enable_whole_network_cuda_graph Signed-off-by: Vasudevan Rengasamy <[email protected]> Change Full Iteration CUDA graph argument name Change to check for partial CUDA graph condition with enable_cuda_graph flag Apply isort and black reformatting Signed-off-by: vasunvidia <[email protected]> Signed-off-by: Vasudevan Rengasamy <[email protected]> Use enable_cuda_graph+cuda_graph_scope for full iteration CG Signed-off-by: Vasudevan Rengasamy <[email protected]> Fix bug for VPP>1 Signed-off-by: Vasudevan Rengasamy <[email protected]> Add comments. Signed-off-by: Vasudevan Rengasamy <[email protected]> Add comments. Signed-off-by: Vasudevan Rengasamy <[email protected]>
Signed-off-by: Vasudevan Rengasamy <[email protected]>
Signed-off-by: Vasudevan Rengasamy <[email protected]>
Signed-off-by: vasunvidia <[email protected]> Signed-off-by: Vasudevan Rengasamy <[email protected]>
Signed-off-by: Kate Cheng <[email protected]> Signed-off-by: Vasudevan Rengasamy <[email protected]>
Signed-off-by: Chen Cui <[email protected]> Signed-off-by: Vasudevan Rengasamy <[email protected]>
* Tutorial and doc update Signed-off-by: Nune <[email protected]> * Clear outputs from notebook Signed-off-by: Nune <[email protected]> * Update docs/source/asr/models.rst Co-authored-by: Nithin Rao <[email protected]> Signed-off-by: nune-tadevosyan <[email protected]> --------- Signed-off-by: Nune <[email protected]> Signed-off-by: nune-tadevosyan <[email protected]> Co-authored-by: Nithin Rao <[email protected]> Signed-off-by: Vasudevan Rengasamy <[email protected]>
Signed-off-by: Kate Cheng <[email protected]> Signed-off-by: Vasudevan Rengasamy <[email protected]>
Signed-off-by: Kate Cheng <[email protected]> Signed-off-by: Vasudevan Rengasamy <[email protected]>
This reverts commit 00751d5. Signed-off-by: Vasudevan Rengasamy <[email protected]>
This reverts commit af83c2d. Signed-off-by: Vasudevan Rengasamy <[email protected]>
Signed-off-by: Vasudevan Rengasamy <[email protected]>
Signed-off-by: Vasudevan Rengasamy <[email protected]>
Signed-off-by: Vasudevan Rengasamy <[email protected]>
Signed-off-by: vasunvidia <[email protected]>
Signed-off-by: Vasudevan Rengasamy <[email protected]>
erhoo82
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Enables Full iteration CUDA graph for NeMo models.
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information