Interface to enable fsdp-double-buffer without enabling NCCL-UB #14076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Youngeun Kwon <[email protected]>
Signed-off-by: Youngeun Kwon <[email protected]>
Signed-off-by: Youngeun Kwon <[email protected]>
Signed-off-by: youngeunkwon0405 <[email protected]>
malay-nagda
reviewed
Jul 1, 2025
|
@youngeunkwon0405 can you also make changes for vlm and diffusion (flux, neva, llama4) perf scripts ( |
Signed-off-by: Youngeun Kwon <[email protected]>
Sure, updated. |
Signed-off-by: Youngeun Kwon <[email protected]>
|
@youngeunkwon0405 is this ready to merge? |
I think it is okay to merge. But there was a performance bug in mcore related to fsdp-double-buffer and we are waiting for the fix to merge to perform final test from the NeMo side. |
Signed-off-by: Youngeun Kwon <[email protected]>
Signed-off-by: youngeunkwon0405 <[email protected]>
erhoo82
approved these changes
Jul 2, 2025
erhoo82
added
r2.4.0
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Jul 23, 2025
…IA-NeMo#14076) * interface draft Signed-off-by: Youngeun Kwon <[email protected]> * minor change Signed-off-by: Youngeun Kwon <[email protected]> * fix the script Signed-off-by: Youngeun Kwon <[email protected]> * Apply isort and black reformatting Signed-off-by: youngeunkwon0405 <[email protected]> * vlm Signed-off-by: Youngeun Kwon <[email protected]> * diffusion Signed-off-by: Youngeun Kwon <[email protected]> * argument validation Signed-off-by: Youngeun Kwon <[email protected]> * Apply isort and black reformatting Signed-off-by: youngeunkwon0405 <[email protected]> --------- Signed-off-by: Youngeun Kwon <[email protected]> Signed-off-by: youngeunkwon0405 <[email protected]> Co-authored-by: youngeunkwon0405 <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
…IA-NeMo#14076) * interface draft Signed-off-by: Youngeun Kwon <[email protected]> * minor change Signed-off-by: Youngeun Kwon <[email protected]> * fix the script Signed-off-by: Youngeun Kwon <[email protected]> * Apply isort and black reformatting Signed-off-by: youngeunkwon0405 <[email protected]> * vlm Signed-off-by: Youngeun Kwon <[email protected]> * diffusion Signed-off-by: Youngeun Kwon <[email protected]> * argument validation Signed-off-by: Youngeun Kwon <[email protected]> * Apply isort and black reformatting Signed-off-by: youngeunkwon0405 <[email protected]> --------- Signed-off-by: Youngeun Kwon <[email protected]> Signed-off-by: youngeunkwon0405 <[email protected]> Co-authored-by: youngeunkwon0405 <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
…IA-NeMo#14076) * interface draft Signed-off-by: Youngeun Kwon <[email protected]> * minor change Signed-off-by: Youngeun Kwon <[email protected]> * fix the script Signed-off-by: Youngeun Kwon <[email protected]> * Apply isort and black reformatting Signed-off-by: youngeunkwon0405 <[email protected]> * vlm Signed-off-by: Youngeun Kwon <[email protected]> * diffusion Signed-off-by: Youngeun Kwon <[email protected]> * argument validation Signed-off-by: Youngeun Kwon <[email protected]> * Apply isort and black reformatting Signed-off-by: youngeunkwon0405 <[email protected]> --------- Signed-off-by: Youngeun Kwon <[email protected]> Signed-off-by: youngeunkwon0405 <[email protected]> Co-authored-by: youngeunkwon0405 <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
…IA-NeMo#14076) * interface draft Signed-off-by: Youngeun Kwon <[email protected]> * minor change Signed-off-by: Youngeun Kwon <[email protected]> * fix the script Signed-off-by: Youngeun Kwon <[email protected]> * Apply isort and black reformatting Signed-off-by: youngeunkwon0405 <[email protected]> * vlm Signed-off-by: Youngeun Kwon <[email protected]> * diffusion Signed-off-by: Youngeun Kwon <[email protected]> * argument validation Signed-off-by: Youngeun Kwon <[email protected]> * Apply isort and black reformatting Signed-off-by: youngeunkwon0405 <[email protected]> --------- Signed-off-by: Youngeun Kwon <[email protected]> Signed-off-by: youngeunkwon0405 <[email protected]> Co-authored-by: youngeunkwon0405 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information