Skip to content

Conversation

@nithinraok
Copy link
Collaborator

  • move classes to module to use target feature

  • Apply isort and black reformatting

Cherry pick #14023


Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

* move classes to module to use __target__ feature

Signed-off-by: nithinraok <[email protected]>

* Apply isort and black reformatting

Signed-off-by: nithinraok <[email protected]>

---------

Signed-off-by: nithinraok <[email protected]>
Signed-off-by: nithinraok <[email protected]>
Co-authored-by: nithinraok <[email protected]>
Copy link
Collaborator

@chtruong814 chtruong814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast merging since this is just a tutorial fix.

@chtruong814 chtruong814 merged commit d1ae536 into main Jun 26, 2025
34 of 35 checks passed
@chtruong814 chtruong814 deleted the update_tutorial_nemo-models branch June 26, 2025 17:04
@chtruong814 chtruong814 added the r2.3.0 Pick this label for auto-cherrypicking into v2.3.0 label Jun 26, 2025
chtruong814 pushed a commit that referenced this pull request Jun 27, 2025
* move classes to module to use __target__ feature

* Apply isort and black reformatting

---------

Signed-off-by: nithinraok <[email protected]>
Signed-off-by: nithinraok <[email protected]>
Co-authored-by: nithinraok <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
chtruong814 added a commit that referenced this pull request Jun 29, 2025
…14043)

* move classes to module to use __target__ feature

* Apply isort and black reformatting

---------

Signed-off-by: nithinraok <[email protected]>
Signed-off-by: nithinraok <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Co-authored-by: nithinraok <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Jul 23, 2025
…VIDIA-NeMo#14031)

* move classes to module to use __target__ feature

* Apply isort and black reformatting

---------

Signed-off-by: nithinraok <[email protected]>
Signed-off-by: nithinraok <[email protected]>
Co-authored-by: nithinraok <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
…VIDIA-NeMo#14031)

* move classes to module to use __target__ feature

* Apply isort and black reformatting

---------

Signed-off-by: nithinraok <[email protected]>
Signed-off-by: nithinraok <[email protected]>
Co-authored-by: nithinraok <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
…VIDIA-NeMo#14031)

* move classes to module to use __target__ feature

* Apply isort and black reformatting

---------

Signed-off-by: nithinraok <[email protected]>
Signed-off-by: nithinraok <[email protected]>
Co-authored-by: nithinraok <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
…VIDIA-NeMo#14031)

* move classes to module to use __target__ feature



* Apply isort and black reformatting



---------

Signed-off-by: nithinraok <[email protected]>
Signed-off-by: nithinraok <[email protected]>
Co-authored-by: nithinraok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r2.3.0 Pick this label for auto-cherrypicking into v2.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants