Skip to content

Conversation

@akoumpa
Copy link
Collaborator

@akoumpa akoumpa commented Jun 24, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Adds a callback to implement Dynamic Layer Freezing previously available in NeMo 1.0.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

akoumpa added 4 commits June 24, 2025 10:12
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the akoumparouli/automodel_freeze_modules branch from bb4e9f3 to 36cbe57 Compare June 24, 2025 17:15
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa marked this pull request as ready for review June 24, 2025 17:16
@akoumpa akoumpa added r2.4.0 Pick this label for auto-cherry-picking into r2.4.0 Run CICD labels Jun 24, 2025
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jun 24, 2025
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the akoumparouli/automodel_freeze_modules branch from 49c64c5 to 52abcaf Compare June 24, 2025 17:17
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jun 24, 2025
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@github-actions github-actions bot removed the Run CICD label Jun 24, 2025
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the akoumparouli/automodel_freeze_modules branch from b366758 to 9257d12 Compare June 24, 2025 17:20
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the akoumparouli/automodel_freeze_modules branch from 5bb7c6d to 8de4228 Compare June 24, 2025 17:25
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the akoumparouli/automodel_freeze_modules branch from b679c00 to 4812617 Compare June 24, 2025 17:40
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jun 24, 2025
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the akoumparouli/automodel_freeze_modules branch from b961cae to 50b032e Compare June 24, 2025 18:37
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jun 25, 2025
@chtruong814
Copy link
Collaborator

@akoumpa That test failure should be unrelated. We're going to make it optional. Please get a review, and I can merge this for you.

@HuiyingLi HuiyingLi self-requested a review June 28, 2025 19:18
Copy link
Collaborator

@HuiyingLi HuiyingLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chtruong814 chtruong814 merged commit cdfe30b into main Jun 29, 2025
413 of 423 checks passed
@chtruong814 chtruong814 deleted the akoumparouli/automodel_freeze_modules branch June 29, 2025 01:38
ko3n1g pushed a commit that referenced this pull request Jun 29, 2025
* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add steps

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add docstring

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* foix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

* Update layer_freezer.py

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

---------

Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: akoumpa <[email protected]>
Co-authored-by: Charlie Truong <[email protected]>
chtruong814 added a commit that referenced this pull request Jun 29, 2025
* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add steps

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add docstring

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* foix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

* Update layer_freezer.py

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

---------

Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: akoumpa <[email protected]>
Co-authored-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Jul 23, 2025
* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add steps

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add docstring

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* foix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

* Update layer_freezer.py

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

---------

Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: akoumpa <[email protected]>
Co-authored-by: Charlie Truong <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add steps

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add docstring

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* foix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

* Update layer_freezer.py

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

---------

Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: akoumpa <[email protected]>
Co-authored-by: Charlie Truong <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add steps

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add docstring

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* foix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

* Update layer_freezer.py

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

---------

Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: akoumpa <[email protected]>
Co-authored-by: Charlie Truong <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add support for layer-freezing

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add steps

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* add docstring

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* foix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

* Update layer_freezer.py

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* Apply isort and black reformatting

Signed-off-by: akoumpa <[email protected]>

---------

Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: akoumpa <[email protected]>
Co-authored-by: Charlie Truong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r2.4.0 Pick this label for auto-cherry-picking into r2.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants