ci: Set L2_NeMo_2_Export_Deploy_Query_In_Framework to be optional#13946
Merged
chtruong814 merged 1 commit intomainfrom Jun 22, 2025
Merged
ci: Set L2_NeMo_2_Export_Deploy_Query_In_Framework to be optional#13946chtruong814 merged 1 commit intomainfrom
chtruong814 merged 1 commit intomainfrom
Conversation
Signed-off-by: Charlie Truong <[email protected]>
chtruong814
requested review from
ko3n1g,
pablo-garay and
thomasdhc
as code owners
ko3n1g
approved these changes
Jun 17, 2025
chtruong814
added a commit
that referenced
this pull request
Jul 7, 2025
Signed-off-by: Charlie Truong <[email protected]>
chtruong814
added a commit
that referenced
this pull request
Jul 7, 2025
…899)` into `r2.4.0` (#14145) * Bump to pytorch 25.05 container along with TE update (#13899) * Update base container to be pytorch:25.05-py3 Signed-off-by: Charlie Truong <[email protected]> * Update TE to 2.4 Signed-off-by: Charlie Truong <[email protected]> * Remove torch accelerator patch Signed-off-by: Charlie Truong <[email protected]> * Update triton patch Signed-off-by: Charlie Truong <[email protected]> * Bump TE and Mcore commits Signed-off-by: Charlie Truong <[email protected]> * Fix triton patch Signed-off-by: Charlie Truong <[email protected]> * Fix triton patch Signed-off-by: Charlie Truong <[email protected]> * No fail fast Signed-off-by: Charlie Truong <[email protected]> * Update trt-llm to 0.20.0 Signed-off-by: Charlie Truong <[email protected]> * Fix test_sched_config_parse_reduce_on_plateau Signed-off-by: Charlie Truong <[email protected]> * Add no build isolation to TE Signed-off-by: Charlie Truong <[email protected]> * Update trt-llm dependencies Signed-off-by: Charlie Truong <[email protected]> * Update manifest Signed-off-by: Charlie Truong <[email protected]> * Revert "Enable LoRA for TELinear layers (#13929)" This reverts commit 7d9f40f. * update mcore with wd_mult key fix Signed-off-by: oliver könig <[email protected]> * Revert "Revert "Enable LoRA for TELinear layers (#13929)"" This reverts commit 5a1da6c. Signed-off-by: Charlie Truong <[email protected]> * Fix nemo install Signed-off-by: Charlie Truong <[email protected]> * Fix nemo install Signed-off-by: Charlie Truong <[email protected]> * Fix export image build Signed-off-by: Charlie Truong <[email protected]> * Remove unnecessary sed for torch_tensorrt Signed-off-by: Charlie Truong <[email protected]> * Update TE and Mcore commits Signed-off-by: Charlie Truong <[email protected]> * Add optional tests Signed-off-by: Charlie Truong <[email protected]> * Fix install Signed-off-by: Charlie Truong <[email protected]> * Ensure test script arg types are correct for top_p and top_k Signed-off-by: Charlie Truong <[email protected]> * Increase export deploy timeouts Signed-off-by: Charlie Truong <[email protected]> * Skip failing test_rnnt_logprobs_random after pytorch bump Signed-off-by: Charlie Truong <[email protected]> * Skip coverage artifact config-3.12.py Signed-off-by: Charlie Truong <[email protected]> * Include more config files ot exclude during coverage Signed-off-by: Charlie Truong <[email protected]> * Update dependencies Signed-off-by: Charlie Truong <[email protected]> * Ensure top_p is float in nemo_export test script Signed-off-by: Charlie Truong <[email protected]> * Set Optional_L2_Speech_Batch_Size_OOMptimizer_Canary to truly be optional Signed-off-by: Charlie Truong <[email protected]> * Fix top_k and top_p types in megatronllm_deployable Signed-off-by: Charlie Truong <[email protected]> * Revert "Skip failing test_rnnt_logprobs_random after pytorch bump" This reverts commit c6c3a76. Signed-off-by: Charlie Truong <[email protected]> * Fix optional export test Signed-off-by: Charlie Truong <[email protected]> * Revert unnecessary changes Signed-off-by: Charlie Truong <[email protected]> --------- Signed-off-by: Charlie Truong <[email protected]> Signed-off-by: oliver könig <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: oliver könig <[email protected]> * Set L2_NeMo_2_Export_Deploy_Query_In_Framework to be optional (#13946) Signed-off-by: Charlie Truong <[email protected]> --------- Signed-off-by: Charlie Truong <[email protected]> Signed-off-by: oliver könig <[email protected]> Co-authored-by: Charlie Truong <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Jul 23, 2025
…-NeMo#13946) Signed-off-by: Charlie Truong <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
…-NeMo#13946) Signed-off-by: Charlie Truong <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96
pushed a commit
to AmirHussein96/NeMo
that referenced
this pull request
Aug 5, 2025
…-NeMo#13946) Signed-off-by: Charlie Truong <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
…-NeMo#13946) Signed-off-by: Charlie Truong <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Set L2_NeMo_2_Export_Deploy_Query_In_Framework to be optional. It's currently failing on the main branch.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information