Skip to content

Conversation

@gdengk
Copy link
Collaborator

@gdengk gdengk commented Jun 16, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Gao Deng <[email protected]>
@gdengk gdengk force-pushed the gaod/llama4/tp_comm_overlap_vlm branch from c9c5a4e to c7635fd Compare June 16, 2025 21:52
@gdengk gdengk requested a review from yaoyu-33 June 16, 2025 21:53
@gdengk gdengk self-assigned this Jun 16, 2025
@yaoyu-33 yaoyu-33 enabled auto-merge (squash) June 16, 2025 22:00
@yaoyu-33 yaoyu-33 merged commit 7b2fee1 into NVIDIA-NeMo:main Jun 17, 2025
220 checks passed
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Jul 23, 2025
Signed-off-by: Gao Deng <[email protected]>
Co-authored-by: Gao Deng <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
Signed-off-by: Gao Deng <[email protected]>
Co-authored-by: Gao Deng <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
Signed-off-by: Gao Deng <[email protected]>
Co-authored-by: Gao Deng <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
Signed-off-by: Gao Deng <[email protected]>
Co-authored-by: Gao Deng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants