Skip to content

Conversation

@emmanuel-ferdman
Copy link
Contributor

@emmanuel-ferdman emmanuel-ferdman commented May 30, 2025

What does this PR do ?

The logger.warn() method is deprecated since Python2.7 and replaced with logger.warning(). It leads to those warnings:

DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead

Also, in retro_dataset.py it uses from nemo.utils import logging which does not even have .warn method available, meaning this is a bug.

Collection: asr, common, nlp.

Changelog

Modernize logger interface

Usage

  • You can potentially add a usage example below
from nemo.utils import logging
logging.warn("test is a test")

import logging
logging.warn("test is a test")

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Emmanuel Ferdman <[email protected]>
Signed-off-by: emmanuel-ferdman <[email protected]>
Copy link
Collaborator

@stevehuang52 stevehuang52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@emmanuel-ferdman
Copy link
Contributor Author

@stevehuang52 looks like the CI complains on not-related linting issues in the same file. What should be done in this case?

@stevehuang52
Copy link
Collaborator

@stevehuang52 looks like the CI complains on not-related linting issues in the same file. What should be done in this case?

No worries, I got this

@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jun 24, 2025
@stevehuang52 stevehuang52 enabled auto-merge (squash) June 24, 2025 17:11
@stevehuang52 stevehuang52 merged commit cfb3a82 into NVIDIA-NeMo:main Jun 25, 2025
250 checks passed
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Jul 23, 2025
* Modernize logger interface

Signed-off-by: Emmanuel Ferdman <[email protected]>

* Apply isort and black reformatting

Signed-off-by: emmanuel-ferdman <[email protected]>

---------

Signed-off-by: Emmanuel Ferdman <[email protected]>
Signed-off-by: emmanuel-ferdman <[email protected]>
Co-authored-by: emmanuel-ferdman <[email protected]>
Co-authored-by: He Huang (Steve) <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
* Modernize logger interface

Signed-off-by: Emmanuel Ferdman <[email protected]>

* Apply isort and black reformatting

Signed-off-by: emmanuel-ferdman <[email protected]>

---------

Signed-off-by: Emmanuel Ferdman <[email protected]>
Signed-off-by: emmanuel-ferdman <[email protected]>
Co-authored-by: emmanuel-ferdman <[email protected]>
Co-authored-by: He Huang (Steve) <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
AmirHussein96 pushed a commit to AmirHussein96/NeMo that referenced this pull request Aug 5, 2025
* Modernize logger interface

Signed-off-by: Emmanuel Ferdman <[email protected]>

* Apply isort and black reformatting

Signed-off-by: emmanuel-ferdman <[email protected]>

---------

Signed-off-by: Emmanuel Ferdman <[email protected]>
Signed-off-by: emmanuel-ferdman <[email protected]>
Co-authored-by: emmanuel-ferdman <[email protected]>
Co-authored-by: He Huang (Steve) <[email protected]>
Signed-off-by: Amir Hussein <[email protected]>
nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
* Modernize logger interface

Signed-off-by: Emmanuel Ferdman <[email protected]>

* Apply isort and black reformatting

Signed-off-by: emmanuel-ferdman <[email protected]>

---------

Signed-off-by: Emmanuel Ferdman <[email protected]>
Signed-off-by: emmanuel-ferdman <[email protected]>
Co-authored-by: emmanuel-ferdman <[email protected]>
Co-authored-by: He Huang (Steve) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants