-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Modernize logger interface #13783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize logger interface #13783
Conversation
Signed-off-by: Emmanuel Ferdman <[email protected]>
Signed-off-by: emmanuel-ferdman <[email protected]>
stevehuang52
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
@stevehuang52 looks like the CI complains on not-related linting issues in the same file. What should be done in this case? |
No worries, I got this |
* Modernize logger interface Signed-off-by: Emmanuel Ferdman <[email protected]> * Apply isort and black reformatting Signed-off-by: emmanuel-ferdman <[email protected]> --------- Signed-off-by: Emmanuel Ferdman <[email protected]> Signed-off-by: emmanuel-ferdman <[email protected]> Co-authored-by: emmanuel-ferdman <[email protected]> Co-authored-by: He Huang (Steve) <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
* Modernize logger interface Signed-off-by: Emmanuel Ferdman <[email protected]> * Apply isort and black reformatting Signed-off-by: emmanuel-ferdman <[email protected]> --------- Signed-off-by: Emmanuel Ferdman <[email protected]> Signed-off-by: emmanuel-ferdman <[email protected]> Co-authored-by: emmanuel-ferdman <[email protected]> Co-authored-by: He Huang (Steve) <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
* Modernize logger interface Signed-off-by: Emmanuel Ferdman <[email protected]> * Apply isort and black reformatting Signed-off-by: emmanuel-ferdman <[email protected]> --------- Signed-off-by: Emmanuel Ferdman <[email protected]> Signed-off-by: emmanuel-ferdman <[email protected]> Co-authored-by: emmanuel-ferdman <[email protected]> Co-authored-by: He Huang (Steve) <[email protected]> Signed-off-by: Amir Hussein <[email protected]>
* Modernize logger interface Signed-off-by: Emmanuel Ferdman <[email protected]> * Apply isort and black reformatting Signed-off-by: emmanuel-ferdman <[email protected]> --------- Signed-off-by: Emmanuel Ferdman <[email protected]> Signed-off-by: emmanuel-ferdman <[email protected]> Co-authored-by: emmanuel-ferdman <[email protected]> Co-authored-by: He Huang (Steve) <[email protected]>
What does this PR do ?
The
logger.warn()method is deprecated since Python2.7 and replaced withlogger.warning(). It leads to those warnings:Also, in
retro_dataset.pyit usesfrom nemo.utils import loggingwhich does not even have.warnmethod available, meaning this is a bug.Collection:
asr,common,nlp.Changelog
Modernize logger interface
Usage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information