Skip to content

Conversation

@ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented May 8, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

ko3n1g added 2 commits May 8, 2025 13:17
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g changed the title tests: Disable flaky test ci: Fix trt-llm breakpoint May 8, 2025
@ko3n1g ko3n1g changed the title ci: Fix trt-llm breakpoint ci: Remove trt-llm breakpoint May 8, 2025
@ko3n1g ko3n1g added the Run CICD label May 8, 2025
@github-actions github-actions bot removed the Run CICD label May 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

Due to a major CI change, merges are currently handled by the automation team.
We will reach out to you quickly to merge this PR, but you can always reach us with the following handles:

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@ko3n1g ko3n1g merged commit 6422746 into main May 8, 2025
81 of 82 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/disable-flaky-test-4 branch May 8, 2025 21:40
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request May 9, 2025
* tests: Disable flaky test

Signed-off-by: oliver könig <[email protected]>

* remove breakpoint

Signed-off-by: oliver könig <[email protected]>

---------

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
nithinraok pushed a commit that referenced this pull request May 12, 2025
* added use-fast tokenizer argument (#12986)

Signed-off-by: Francesco Bertolotti <[email protected]>
Co-authored-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* ci: Run selective triggering on dockerfiles and dependencies (#13493)

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* fix buffered inference for tdt

Signed-off-by: Hainan Xu <[email protected]>

* small fixes

Signed-off-by: Hainan Xu <[email protected]>

* [automodel] fallback FP8 + LCE -> FP8 + CE  (#13349)

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* make fp8 tests non-optional

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* switch to gemma

Signed-off-by: Alexandros Koumparoulis <[email protected]>

---------

Signed-off-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Update changelog for `r2.3.0` (#13501)

* beep boop: Update changelog

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add changelog highlights

Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Charlie Truong <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Charlie Truong <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Update 2.3.0 changelog (#13503)

Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* ci: Remove trt-llm breakpoint (#13499)

* tests: Disable flaky test

Signed-off-by: oliver könig <[email protected]>

* remove breakpoint

Signed-off-by: oliver könig <[email protected]>

---------

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Update 2.3.0 changelog (#13504)

* Fix 2.3.0 changelog

Signed-off-by: Charlie Truong <[email protected]>

* Update 2.3.0 changelog

Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Enabling flash decode for float16 precision only (#13471)

Signed-off-by: Pranav Prashant Thombre <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Fix changelog formatting (#13505)

Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Updating the long context performance number for B200 (#13468)

* Add without CP numbers for B200 and merge the captioning texts of both into one.

Signed-off-by: Youngeun Kwon <[email protected]>

* figure removed

Signed-off-by: Youngeun Kwon <[email protected]>

---------

Signed-off-by: Youngeun Kwon <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Autodetect model_type and dtype for deployment using TRT-LLM backend (#13209)

* Autodetect model_type and dtype for deployment using TRT-LLM backed

Signed-off-by: Jan Lasek <[email protected]>

* Handling kv_cache_qformat parameter

Signed-off-by: Jan Lasek <[email protected]>

* Apply isort and black reformatting

Signed-off-by: janekl <[email protected]>

* Docstring update

Signed-off-by: Jan Lasek <[email protected]>

---------

Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: janekl <[email protected]>
Co-authored-by: janekl <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* remove unused variable

Signed-off-by: Hainan Xu <[email protected]>

* Apply isort and black reformatting

Signed-off-by: hainan-xv <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* add doc string, cleaner way of setting mergo_algo

Signed-off-by: Hainan Xu <[email protected]>

* Apply isort and black reformatting

Signed-off-by: hainan-xv <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* add extra hyena tests (#13097)

* add extra hyena tests

* Apply isort and black reformatting

Signed-off-by: JRD971000 <[email protected]>

* fix num gpus

* keep sft optional

---------

Signed-off-by: JRD971000 <[email protected]>
Co-authored-by: JRD971000 <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* ci: Add mode files to filter (#13517)

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* change default merge_algo for buffered inference to None

Signed-off-by: Hainan Xu <[email protected]>

* Apply isort and black reformatting

Signed-off-by: hainan-xv <[email protected]>

---------

Signed-off-by: Francesco Bertolotti <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Pranav Prashant Thombre <[email protected]>
Signed-off-by: Youngeun Kwon <[email protected]>
Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: janekl <[email protected]>
Signed-off-by: hainan-xv <[email protected]>
Signed-off-by: JRD971000 <[email protected]>
Co-authored-by: Francesco Bertolotti <[email protected]>
Co-authored-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Co-authored-by: Hainan Xu <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Charlie Truong <[email protected]>
Co-authored-by: pthombre <[email protected]>
Co-authored-by: Youngeun Kwon <[email protected]>
Co-authored-by: Jan Lasek <[email protected]>
Co-authored-by: janekl <[email protected]>
Co-authored-by: hainan-xv <[email protected]>
Co-authored-by: Ali Taghibakhshi <[email protected]>
Co-authored-by: JRD971000 <[email protected]>
shjwudp pushed a commit to shjwudp/NeMo that referenced this pull request May 31, 2025
* added use-fast tokenizer argument (NVIDIA-NeMo#12986)

Signed-off-by: Francesco Bertolotti <[email protected]>
Co-authored-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* ci: Run selective triggering on dockerfiles and dependencies (NVIDIA-NeMo#13493)

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* fix buffered inference for tdt

Signed-off-by: Hainan Xu <[email protected]>

* small fixes

Signed-off-by: Hainan Xu <[email protected]>

* [automodel] fallback FP8 + LCE -> FP8 + CE  (NVIDIA-NeMo#13349)

* fix

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* make fp8 tests non-optional

Signed-off-by: Alexandros Koumparoulis <[email protected]>

* switch to gemma

Signed-off-by: Alexandros Koumparoulis <[email protected]>

---------

Signed-off-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Update changelog for `r2.3.0` (NVIDIA-NeMo#13501)

* beep boop: Update changelog

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add changelog highlights

Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Charlie Truong <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Charlie Truong <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Update 2.3.0 changelog (NVIDIA-NeMo#13503)

Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* ci: Remove trt-llm breakpoint (NVIDIA-NeMo#13499)

* tests: Disable flaky test

Signed-off-by: oliver könig <[email protected]>

* remove breakpoint

Signed-off-by: oliver könig <[email protected]>

---------

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Update 2.3.0 changelog (NVIDIA-NeMo#13504)

* Fix 2.3.0 changelog

Signed-off-by: Charlie Truong <[email protected]>

* Update 2.3.0 changelog

Signed-off-by: Charlie Truong <[email protected]>

---------

Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Enabling flash decode for float16 precision only (NVIDIA-NeMo#13471)

Signed-off-by: Pranav Prashant Thombre <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Fix changelog formatting (NVIDIA-NeMo#13505)

Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Updating the long context performance number for B200 (NVIDIA-NeMo#13468)

* Add without CP numbers for B200 and merge the captioning texts of both into one.

Signed-off-by: Youngeun Kwon <[email protected]>

* figure removed

Signed-off-by: Youngeun Kwon <[email protected]>

---------

Signed-off-by: Youngeun Kwon <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* Autodetect model_type and dtype for deployment using TRT-LLM backend (NVIDIA-NeMo#13209)

* Autodetect model_type and dtype for deployment using TRT-LLM backed

Signed-off-by: Jan Lasek <[email protected]>

* Handling kv_cache_qformat parameter

Signed-off-by: Jan Lasek <[email protected]>

* Apply isort and black reformatting

Signed-off-by: janekl <[email protected]>

* Docstring update

Signed-off-by: Jan Lasek <[email protected]>

---------

Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: janekl <[email protected]>
Co-authored-by: janekl <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* remove unused variable

Signed-off-by: Hainan Xu <[email protected]>

* Apply isort and black reformatting

Signed-off-by: hainan-xv <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* add doc string, cleaner way of setting mergo_algo

Signed-off-by: Hainan Xu <[email protected]>

* Apply isort and black reformatting

Signed-off-by: hainan-xv <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* add extra hyena tests (NVIDIA-NeMo#13097)

* add extra hyena tests

* Apply isort and black reformatting

Signed-off-by: JRD971000 <[email protected]>

* fix num gpus

* keep sft optional

---------

Signed-off-by: JRD971000 <[email protected]>
Co-authored-by: JRD971000 <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* ci: Add mode files to filter (NVIDIA-NeMo#13517)

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>

* change default merge_algo for buffered inference to None

Signed-off-by: Hainan Xu <[email protected]>

* Apply isort and black reformatting

Signed-off-by: hainan-xv <[email protected]>

---------

Signed-off-by: Francesco Bertolotti <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Pranav Prashant Thombre <[email protected]>
Signed-off-by: Youngeun Kwon <[email protected]>
Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: janekl <[email protected]>
Signed-off-by: hainan-xv <[email protected]>
Signed-off-by: JRD971000 <[email protected]>
Co-authored-by: Francesco Bertolotti <[email protected]>
Co-authored-by: Alexandros Koumparoulis <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Co-authored-by: Hainan Xu <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Charlie Truong <[email protected]>
Co-authored-by: pthombre <[email protected]>
Co-authored-by: Youngeun Kwon <[email protected]>
Co-authored-by: Jan Lasek <[email protected]>
Co-authored-by: janekl <[email protected]>
Co-authored-by: hainan-xv <[email protected]>
Co-authored-by: Ali Taghibakhshi <[email protected]>
Co-authored-by: JRD971000 <[email protected]>
Signed-off-by: jianbinc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants