Skip to content

Revert "WebDataset URL refactoring" #13421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2025
Merged

Revert "WebDataset URL refactoring" #13421

merged 2 commits into from
May 3, 2025

Conversation

@ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented May 3, 2025

Reverts #12905

github-advanced-security[bot]
github-advanced-security bot found potential problems May 3, 2025
View reviewed changes
nemo/collections/multimodal/speech_cv/data/video_to_text.py
from nemo.core.classes import Dataset, IterableDataset
from nemo.core.neural_types import *
from nemo.utils import webdataset as wds
from nemo.utils import logging

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'logging' is not used.

Copilot Autofix

AI 6 months ago

To fix the issue, we will remove the unused import statement from nemo.utils import logging on line 28. This will clean up the code and eliminate the unnecessary dependency. No other changes are required since the removal of this import does not affect the functionality of the code.

Suggested changeset 1
nemo/collections/multimodal/speech_cv/data/video_to_text.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/nemo/collections/multimodal/speech_cv/data/video_to_text.py b/nemo/collections/multimodal/speech_cv/data/video_to_text.py
--- a/nemo/collections/multimodal/speech_cv/data/video_to_text.py
+++ b/nemo/collections/multimodal/speech_cv/data/video_to_text.py
@@ -27,3 +27,2 @@
 from nemo.core.neural_types import *
-from nemo.utils import logging
 from nemo.utils.distributed import webdataset_split_by_workers
EOF
@@ -27,3 +27,2 @@
from nemo.core.neural_types import *
from nemo.utils import logging
from nemo.utils.distributed import webdataset_split_by_workers
Copilot is powered by AI and may make mistakes. Always verify output.
@ko3n1g ko3n1g merged commit 51b6cca into main May 3, 2025
35 of 39 checks passed
@ko3n1g ko3n1g deleted the revert-12905-msekoyan/webdataset_url_fix branch May 3, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ASR Multi Modal TTS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ko3n1g @artbataev