-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat - GPTSFTChatDataset alignment with OpenAI Messages, compatibility with packed sequences #13367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 38 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
effb802
feat - GPTSFTChatDataset alignment with OpenAI Messages, compatibilit…
soluwalana c9bf3f0
feat - GPTSFTChatDataset alignment with OpenAI Messages, compatibilit…
soluwalana f62aa0f
Apply isort and black reformatting
soluwalana aac5d65
lint
soluwalana c65b02e
update test case
soluwalana cfe0d4e
F string lint issue
soluwalana 5b43c01
Lint line length
soluwalana c59d8e1
Apply isort and black reformatting
soluwalana 50f57a8
Apply isort and black reformatting
soluwalana 71d3f7b
More lint
soluwalana e84c9fd
Apply isort and black reformatting
soluwalana e03ca17
More lint
soluwalana 1aa493d
Apply isort and black reformatting
soluwalana 2cc6b76
Missing parameters
soluwalana 99a5bea
Don't download the model everytime
soluwalana ded682d
Code lint
soluwalana 09e5cb5
Rollback change on whitespace in sentencepiece tokenizer
soluwalana 379787b
Ensure all loss_masks are labeled as loss_mask
soluwalana 5697d16
Apply isort and black reformatting
soluwalana 9e42664
Remove duplicate function left in for rebase only"
soluwalana 459a257
label loss mask actually loss mask (as there is an attention mask as …
soluwalana 36956f4
Lint line length
soluwalana 129e3d9
Apply isort and black reformatting
soluwalana 06a1e3b
default use_hf_tokenzier_chat_template = True
soluwalana 2098584
Add original build_samples_mapping back in
soluwalana 1f29e14
PR feedback incorporation
soluwalana 508bea6
Apply isort and black reformatting
soluwalana 5289918
PR feedback incorporation
soluwalana 07109f9
Apply isort and black reformatting
soluwalana e02f960
Fix tests
soluwalana b54ec35
Apply isort and black reformatting
soluwalana 806ac13
PR changes
soluwalana 44d1826
Apply isort and black reformatting
soluwalana 83bc752
Merge branch 'main' into solu/chat-dataset-changes
chtruong814 b80defd
Merge branch 'main' into solu/chat-dataset-changes
chtruong814 a0340fb
Skip eval unit test (#13635)
chtruong814 51fd732
Map directly to the NeMo tokenizer path
soluwalana 464c70b
Rollback change pointing to image cache
soluwalana 65bcaec
Potential fix for code scanning alert no. 14984: Unused import
soluwalana 29fd40b
correct path in TestData
soluwalana 45c66f0
correct path in TestData
soluwalana a74b8e3
Merge branch 'main' into solu/chat-dataset-changes
soluwalana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.