Skip to content

Conversation

@ananthsub
Copy link
Contributor

async saving is by default disabled in the checkpoint config and recipes. this adds the flag to enable this for testing

@ananthsub ananthsub added the testing Request for or addition to test suite label Sep 27, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 27, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ananthsub
Copy link
Contributor Author

/ok to test c6c67b9

Copy link
Contributor

@dimapihtar dimapihtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ananthsub ananthsub merged commit ad94387 into NVIDIA-NeMo:main Oct 3, 2025
44 of 46 checks passed
@ananthsub ananthsub deleted the ci-async-save branch October 3, 2025 11:28
paul-gibbons pushed a commit to paul-gibbons/Megatron-Bridge that referenced this pull request Oct 29, 2025
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Paul Gibbons <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Request for or addition to test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants