[sync] Add option to load main params from checkpoint if load_optim=False
#218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/ok to test 66a8710 |
ananthsub
changed the title
load_optim=False
maanug-nv
requested changes
Jul 9, 2025
Contributor
maanug-nv
left a comment
maanug-nv
left a comment
There was a problem hiding this comment.
Now that CheckpointConfig has a post-init, can we add an idempotency check for that in test_config.TestRerunConfigValidation ?
Signed-off-by: Ananth Subramaniam <[email protected]>
Signed-off-by: Ananth Subramaniam <[email protected]>
ananthsub
force-pushed
the
ckpt-load-main-params
branch
from
66a8710 to
901ae8d
Compare
Contributor
Author
|
/ok to test 901ae8d |
Signed-off-by: Ananth Subramaniam <[email protected]>
Contributor
Author
|
/ok to test e50fcee |
ananthsub
changed the title
load_optim=Falseload_optim=False
yaoyu-33
pushed a commit
that referenced
this pull request
Jul 10, 2025
…c) (#218) Signed-off-by: Sahil Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync with MLM: NVIDIA/Megatron-LM@1e42279
NeMo PR: NVIDIA-NeMo/NeMo#14072