Update performance scripts #1478
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scsudhakaran
force-pushed
the
scsudhakaran/llmb-r0.2.0
branch
2 times, most recently
from
5f17628 to
9a00e84
Compare
scsudhakaran
force-pushed
the
scsudhakaran/llmb-r0.2.0
branch
3 times, most recently
from
f2856bc to
0af5c29
Compare
bdubauski
reviewed
Nov 25, 2025
Comment on lines
+279
to
+287
| layout_map = { | ||
| (1, 1): None, | ||
| (4, 1): [["embedding"] + ["decoder"] * 16, ["decoder"] * 16, ["decoder"] * 16, ["decoder"] * 13 + last_layer], | ||
| (8, 1): [["embedding"] + ["decoder"] * 8] + [["decoder"] * 8] * 6 + [["decoder"] * 5 + last_layer], | ||
| (4, 2): [["embedding"] + ["decoder"] * 8] + [["decoder"] * 8] * 6 + [["decoder"] * 5 + last_layer], | ||
| (16, 1): [["embedding"] + ["decoder"] * 4] + [["decoder"] * 4] * 14 + [["decoder"] + last_layer], | ||
| (8, 2): [["embedding"] + ["decoder"] * 4] + [["decoder"] * 4] * 14 + [["decoder"] + last_layer], | ||
| (4, 4): [["embedding"] + ["decoder"] * 4] + [["decoder"] * 4] * 14 + [["decoder"] + last_layer], | ||
| } |
There was a problem hiding this comment.
What is the source material for this layout map? It appears to be unique to ds v3 recipe.
Contributor
Author
There was a problem hiding this comment.
We had to set this layout again because of the issue mentioned here: #1502
- Megatron-Bridge creates the recipe with default values.
- If user passes parallelism configs it overrides the recipe attributes with user given ones.
- The layout needs to be updated with the final PP-VP setting. This code block handles that.
Signed-off-by: Sanju C Sudhakaran <[email protected]>
Signed-off-by: Sanju C Sudhakaran <[email protected]>
Signed-off-by: Sanju C Sudhakaran <[email protected]>
scsudhakaran
force-pushed
the
scsudhakaran/llmb-r0.2.0
branch
from
0af5c29 to
648fe39
Compare
Signed-off-by: Sanju C Sudhakaran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.