This repository was archived by the owner on Oct 10, 2023. It is now read-only.
Update UI variables and add theme colors#2
Merged
NSHenry merged 14 commits intoNSHenry:masterfrom Mar 12, 2016
Merged
Conversation
The icons were difficult to see when a message was focued, both when active and inactive. Resolves: noahbuscher#22
Update N1-Taiga theme to new changes in N1
Fix stars and draft icons on focused messages
Add display name and colors for theme picker
NSHenry
added a commit
that referenced
this pull request
Mar 12, 2016
Update UI variables and add theme colors
Owner
|
Apologies for the ridiculously late reply I didn't realize that it wasn't notifying me. I am so sorry. I'll commit to more actively stay on top of this. |
Author
|
@NSHenry No worries, thanks for merging! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, @NSHenry! I'm part of the Nylas team, and we're about to land a new visual theme picker that'll allow people to preview and view color palettes for themes. We pull a few major colors from the theme's UI variables to create the palette, but we've also added a way to override them manually with a theme-colors.less file for themes (like yours) that aren't conveyed well with the variables we selected.
Before:
After:
I also pulled everything into the root directory for the project, since we've had a lot of people who are confused when they try to install using that directory and it doesn't work, and it might also be easier for them to
git pullupdates there. Let me know what you think!