This repository was archived by the owner on Jan 7, 2018. It is now read-only.
Fix handling of long hostnames #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible that nginx would bomb if an API backend was added with a long hostname. The exact length that would trigger this error varied, since nginx's default lengths actually varied depending on the CPU type. But this should fix things so that we should properly support hostnames up to 110 characters long regardless of CPU defaults. Fixes NREL/api-umbrella#168
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible that nginx would bomb if an API backend was added with a long hostname. The exact length that would trigger this error varied, since nginx's default lengths actually varied depending on the CPU type. But this should fix things so that we should properly support hostnames up to 110 characters long regardless of CPU defaults.
Fixes NREL/api-umbrella#168