Skip to content

Conversation

@shorowit
Copy link
Contributor

@shorowit shorowit commented Oct 31, 2025

Pull Request Description

Fixes possible ground-source heat pump sizing error if the heating or cooling design temperature differences are zero.

Small diffs expected for HPXMLs w/ autosized GSHPs.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.sch) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

… cooling design temperature differences are zero.
@shorowit shorowit marked this pull request as ready for review October 31, 2025 22:06
@shorowit shorowit merged commit 573a64e into master Nov 4, 2025
7 checks passed
@shorowit shorowit deleted the gshp_sizing_error branch November 4, 2025 16:34
@github-project-automation github-project-automation bot moved this from Triage to Done in OpenStudio-HPXML Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants