Skip to content

Conversation

@joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Sep 11, 2024

Pull Request Description

In the BuildResidentialHPXML measure, replaces:

  • schedules_vacancy_periods
  • schedules_power_outage_periods
  • schedules_power_outage_periods_window_natvent_availability

With:

  • schedules_unavailable_period_types
  • schedules_unavailable_period_dates
  • schedules_unavailable_period_window_natvent_availabilities

Also updates unavailable_periods.csv with:

  • new column names No Space Heating and No Space Cooling
  • replace row hvac with rows space_heating and space_cooling

Space heating and cooling can now be controlled independently.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@joseph-robertson joseph-robertson self-assigned this Sep 11, 2024
@joseph-robertson joseph-robertson marked this pull request as ready for review September 11, 2024 16:55
@shorowit shorowit changed the title Support for zero day heating/cooling seasons Support for year-round heating/cooling unavailability Sep 16, 2024
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall approach looks reasonable, but I did have a few questions/suggestions.

Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Assuming I didn't break anything in my last commit, this can go in. Thanks @joseph-robertson.

@shorowit shorowit merged commit 11bb6ec into master Sep 17, 2024
@shorowit shorowit deleted the no-hvac-season branch September 17, 2024 22:59
@joseph-robertson joseph-robertson mentioned this pull request Sep 17, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants