-
Notifications
You must be signed in to change notification settings - Fork 26
Support for year-round heating/cooling unavailability #1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
shorowit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall approach looks reasonable, but I did have a few questions/suggestions.
shorowit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Assuming I didn't break anything in my last commit, this can go in. Thanks @joseph-robertson.
Pull Request Description
In the BuildResidentialHPXML measure, replaces:
schedules_vacancy_periodsschedules_power_outage_periodsschedules_power_outage_periods_window_natvent_availabilityWith:
schedules_unavailable_period_typesschedules_unavailable_period_datesschedules_unavailable_period_window_natvent_availabilitiesAlso updates
unavailable_periods.csvwith:No Space HeatingandNo Space Coolinghvacwith rowsspace_heatingandspace_coolingSpace heating and cooling can now be controlled independently.
Checklist
Not all may apply:
Schematron validator (EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)Tests have been added/updated (e.g.,HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run