Allow optional window inputs: InteriorShading/Type, ExteriorShading/Type, and InsectScreen
#1826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
shorowit
changed the title
Window/ExteriorShading/TypeWindow/ExteriorShading/Type and Window/InsectScreen
shorowit
changed the base branch from
more_bob_ross_cases
to
Bob_Ross_del_4_5
…o exterior_shading_type
…ts to be more conservative.
shorowit
changed the title
Window/ExteriorShading/Type and Window/InsectScreenInteriorShading/Type, ExteriorShading/Type, and Window/InsectScreen
…o exterior_shading_type # Conflicts: # BuildResidentialHPXML/measure.xml # HPXMLtoOpenStudio/measure.xml # ReportUtilityBills/measure.xml
shorowit
changed the title
InteriorShading/Type, ExteriorShading/Type, and Window/InsectScreenInteriorShading/Type, ExteriorShading/Type, and InsectScreen
…o exterior_shading_type # Conflicts: # BuildResidentialHPXML/measure.xml # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/hvac_sizing.rb # ReportUtilityBills/measure.xml # workflow/tests/base_results/results_acca_hvac.csv # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv
…Expand sample files.
…tudio-HPXML into exterior_shading_type
…tudio-HPXML into exterior_shading_type
26 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #1701. Spreadsheet for interior shading and insect screen derivations: WindowShading.xlsx
Interior shading
New inputs that can be used to default the interior shading summer/winter fractions:
Type(blinds/shades/curtains, dark/medium/light)SummerFractionCoveredandWinterFractionCoveredBlindsSummerClosedOrOpenandBlindsWinterClosedOrOpen(closed, half open, open)Defaults are calculated based on data from ASHRAE 1311-RP; see the attached spreadsheet above for derivations.
Exterior shading
New inputs that can be used to default the exterior shading summer/winter fractions:
Type(solar screens/films, trees, etc.)SummerFractionCoveredandWinterFractionCoveredDefaulting is based on either assumptions from MulTEA or engineering judgment.
Insect screen
New inputs that can be used to specify, or default, insect screen summer/winter fractions:
Location(exterior or interior)SummerFractionCoveredandWinterFractionCoveredSummerShadingCoefficientandWinterShadingCoefficientDefaults are calculated based on data from ASHRAE 1311-RP; see the attached spreadsheet above for derivations.
Checklist
Not all may apply:
EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run