Skip to content

Conversation

@shorowit
Copy link
Contributor

@shorowit shorowit commented Sep 4, 2024

Pull Request Description

Closes #1818. Reduces number of sample files with 1-minute timesteps to speed up CI jobs.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Sep 4, 2024
@shorowit
Copy link
Contributor Author

shorowit commented Sep 4, 2024

@yzhou601 I took a cut at this. It reduced the CI runtime by 15 minutes.

@shorowit shorowit requested a review from yzhou601 September 4, 2024 17:55
@yzhou601
Copy link
Collaborator

yzhou601 commented Sep 5, 2024

@yzhou601 I took a cut at this. It reduced the CI runtime by 15 minutes.

Thanks for taking a first cut, it sounds promising! I'm good with the changes you made to test files, except one that I commented out.

@shorowit
Copy link
Contributor Author

shorowit commented Sep 6, 2024

Thanks @yzhou601!

@shorowit shorowit merged commit 80b39ec into master Sep 6, 2024
@shorowit shorowit deleted the reduce-advanced-feature-simulations branch September 6, 2024 15:58
@joseph-robertson joseph-robertson mentioned this pull request Sep 11, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Reduce number of Timestep=1 simulations on CI

3 participants