Expose HVAC Detailed Performance Data inputs #715
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorowit
reviewed
Feb 21, 2024
shorowit
reviewed
Feb 26, 2024
…enStudio-ERI into expose_hvac_detailed_perf_inputs
… expose_hvac_detailed_perf_inputs
…enStudio-ERI into expose_hvac_detailed_perf_inputs
… expose_hvac_detailed_perf_inputs
shorowit
reviewed
Mar 8, 2024
Collaborator
shorowit
left a comment
shorowit
left a comment
There was a problem hiding this comment.
This is getting close, just a couple more things to do.
…enStudio-ERI into expose_hvac_detailed_perf_inputs
… expose_hvac_detailed_perf_inputs
shorowit
approved these changes
Mar 11, 2024
Collaborator
shorowit
left a comment
shorowit
left a comment
There was a problem hiding this comment.
Nice job, looks great. We're going to hold off on merging this in to master for now, but the branch can be used for any analysis projects.
shorowit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Expose HVAC Detailed Performance Data so that we can accommodate cold climate heat pump performance data from the NEEP database or manufacturer's data.
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
OS-HPXML git subtree has been pulledopenstudio tasks.rb update_measureshas been run