Skip to content

Control verbosity of debug output via build config#58

Draft
robertbartel wants to merge 11 commits intoNOAA-OWP:masterfrom
robertbartel:f/build_improvements/control_verbosity
Draft

Control verbosity of debug output via build config#58
robertbartel wants to merge 11 commits intoNOAA-OWP:masterfrom
robertbartel:f/build_improvements/control_verbosity

Conversation

@robertbartel
Copy link
Contributor

Note this depends on #57 and should remain in draft status until that PR is finished.

Control verbosity of debug output using CMake variable DEBUG_VERBOSITY, rather than hard coding.

Removals

  • Hard-coded setting of TOPMODEL_DEBUG

Changes

  • CMake build adjusted to accept a DEBUG_VERBOSITY variable and use that to set the TOPMODEL_DEBUG macro via compile definition.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@robertbartel robertbartel added the enhancement New feature or request label Feb 17, 2026
@robertbartel robertbartel force-pushed the f/build_improvements/control_verbosity branch 5 times, most recently from 2744a24 to 61f3c89 Compare February 17, 2026 16:12
Include targets for driver, shared lib, and existing simple test routine; remove old make files.
To align with new CMake build setup.
Make sure the C flags are passed in this variable rather than just on
the command line.
Setting macro TOPMODEL_DEBUG via new CMake DEBUG_VERBOSITY variable,
rather than hard-coding directly within topmodel.h.
Applying verbosity controls via TOPMODEL_DEBUG macro to a statment in
topmodel.c hat brings the "subcat" as read from the config file.
@robertbartel robertbartel force-pushed the f/build_improvements/control_verbosity branch from ec52aa8 to 65f508e Compare March 5, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant