Skip to content

Adding refkdt to config file#8

Merged
madMatchstick merged 6 commits intoNOAA-OWP:masterfrom
lcunha0118:master
Sep 17, 2021
Merged

Adding refkdt to config file#8
madMatchstick merged 6 commits intoNOAA-OWP:masterfrom
lcunha0118:master

Conversation

@lcunha0118
Copy link
Contributor

Add parameters refkdt to the config file

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • [ x] Any change in functionality is tested
  • [ x] New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Copy link
Contributor

@madMatchstick madMatchstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update path -fel ${FelPath}

Copy link
Contributor

@madMatchstick madMatchstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error opening file ${Outdir}${file_name}hf.tif
This echo statement just prior seems off too but unlikely cause of error?

Copy link
Contributor

@madMatchstick madMatchstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer seeing runtime err, looks good!

@madMatchstick madMatchstick merged commit 965109f into NOAA-OWP:master Sep 17, 2021
donaldwj pushed a commit that referenced this pull request Jan 15, 2026
Merge updated warning per OWP to the development branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants