Skip to content

Codes to generate GIUH, extract NWM 2.1 params from hydrofabrics and create config file for CFE. #5

Merged
SnowHydrology merged 5 commits intoNOAA-OWP:masterfrom
lcunha0118:master
Aug 31, 2021
Merged

Codes to generate GIUH, extract NWM 2.1 params from hydrofabrics and create config file for CFE. #5
SnowHydrology merged 5 commits intoNOAA-OWP:masterfrom
lcunha0118:master

Conversation

@lcunha0118
Copy link
Contributor

Adding codes.

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@SnowHydrology
Copy link
Contributor

@lcunha0118, please remove all output files and add their pattern to a .gitignore as @madMatchstick recommended for TOPMODEL

Copy link
Contributor

@SnowHydrology SnowHydrology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further testing needed on other machines because of GDAL and TauDEM versioning.

@SnowHydrology SnowHydrology merged commit 7afd15c into NOAA-OWP:master Aug 31, 2021
madMatchstick referenced this pull request in madMatchstick/cfe Mar 8, 2022
Codes to generate GIUH, extract NWM 2.1 params from hydrofabrics and create config file for CFE.
donaldwj pushed a commit that referenced this pull request Jan 15, 2026
Merge development into release-candidate for release 3.1.1.4.0-rc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants