Merged
Conversation
Contributor
madMatchstick
left a comment
madMatchstick
left a comment
There was a problem hiding this comment.
I understand you are reworking original_author_code but better to keep this directory self-contained.
Contributor
|
Looks good. Output from
|
madMatchstick
referenced
this pull request
in madMatchstick/cfe
Mar 8, 2022
* cfe from alt-modular * cfe function split, segmentation fault * Seperate state-space CFE runs, but mass balance errors * Mass balance working for the CFE state space model and driver * removing executables from git, adding to gitignore in origional_author_code * removing old notes * BMI for CFE state space function * Check mass balance errors through bmi * pass forcings through BMI compiles and runs * cfe bmi with pass forcings producing same results * removing reference to origional_author_code directory * modifying readme with the updatred paths to cfe * removing reference to the AORC BMI * fixing typy in gitignore * removing another reference to the origional author code
donaldwj
pushed a commit
that referenced
this pull request
Jan 15, 2026
Merge release-candidate into development for release 3.1.1.3.0-rc2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Additions
main.c calls runs bmi_cfe.c which runs cfe.c
cfe.h added so can run with main.c and bmi_cfe.c
mass balance check added to bmi_cfe.c
verbosity added as a configuration option to the bmi_cfe.c
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other