Skip to content

Merge master back into Rtx changes#165

Closed
donaldwj wants to merge 10 commits into2024Sep12from
master
Closed

Merge master back into Rtx changes#165
donaldwj wants to merge 10 commits into2024Sep12from
master

Conversation

@donaldwj
Copy link

@donaldwj donaldwj commented Jan 16, 2026

[Short description explaining the high-level reason for the pull request]

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Brian-Cosgrove and others added 10 commits January 31, 2025 09:12
@Brian-Cosgrove @christophertubbs
Updated license file to reflect OWP government language
17b39cb 
Added Apache license and copyright information for cfe repo via modification of existing LICENSE file
@fred-ogden @hellkite500
Update cfe.c (#139)
e041fbb 
* Update cfe.c

Fixed major bug in xinanjiang function.  One minor bass balance fix.  Refactored.  Verified code against NWM Fortran Xinanjiang function.  Changed "infiltation_excess_params_struct" to "infiltration_excess_params_structure".   Added "#ifdef DEBUG #endif around mass balance warning print statement at end of xinanjiang scheme function.

* fix: adjust white space for better review, fix struct parameter

---------

Co-authored-by: hellkite500 <[email protected]>
@hellkite500 @aaraney
ci: use pull_request_target when collecting project info for PR's fro…
ee15b13 
…m forks
@hellkite500 @aaraney
ci: us pull_request_target the right way...
fb94939
@hellkite500 @aaraney
ci: remove duplicate event, pull_request is a subset of pull_request_…
fb5e591 
…target
@fred-ogden @hellkite500
fix: don't double count impervious_runoff in infiltration_excess calc…
8b02c40 
…ulation

Co-authored-by: Nels <[email protected]>
@hellkite500 @ajkhattak
Fix aet, replaces #142 (#143)
889bc30 
* chore: small formatting refactor

Co-authored-by: ajkhattak <[email protected]>

* feat: add method to compute et_from_retention_depth

Co-authored-by: ajkhattak <[email protected]>

* fix: take AET from surface retention depth

Co-authored-by: ajkhattak <[email protected]>

* fix: try to prevent segfault when computing AET from retention depth

---------

Co-authored-by: ajkhattak <[email protected]>
@aaraney @hellkite500
build: broken reference to bmi_cfe header file
c246e17
@hellkite500 @aaraney
fix: ensure volstart is initialized, fixes #152
4a66277
@hellkite500 @aaraney
fix: more CFE pointer initialization and cleanup...
a349a95
@donaldwj donaldwj closed this Jan 20, 2026
@donaldwj
Copy link
Author

donaldwj commented Jan 20, 2026

Closed because github wont pull from the master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@donaldwj @Brian-Cosgrove @fred-ogden @hellkite500 @aaraney