Mass balance BMI protocol implemented#158
Open
hellkite500 wants to merge 6 commits intoNOAA-OWP:masterfrom
Open
Mass balance BMI protocol implemented#158hellkite500 wants to merge 6 commits intoNOAA-OWP:masterfrom
hellkite500 wants to merge 6 commits intoNOAA-OWP:masterfrom
Conversation
hellkite500
commented
Sep 12, 2025
| double volout ; | ||
| double volend ; | ||
| double vol_et_from_retention_depth; | ||
| double cummulative_vol_in; //volstart + volin |
Contributor
Author
There was a problem hiding this comment.
I'm not sure why GitHub is showing so much change on this file, but its really only these three lines (127-129)...
Contributor
There was a problem hiding this comment.
Hiding vs showing whitespace seems to resolve it, so there's probably something in the diff that's whitespace-ish setting it off.
Contributor
Author
There was a problem hiding this comment.
I noticed parts of this code has carriage returns on some line endings, so that's probably why...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a basic mass balance BMI protocol which exposes cumulative mass balance terms via the BMI for consumption by some caller.
Additions
Removals
Changes
Testing
Checklist
Testing checklist
Target Environment support