fix: more CFE pointer initialization and cleanup...#154
Merged
aaraney merged 1 commit intoNOAA-OWP:masterfrom Aug 6, 2025
Merged
fix: more CFE pointer initialization and cleanup...#154aaraney merged 1 commit intoNOAA-OWP:masterfrom
aaraney merged 1 commit intoNOAA-OWP:masterfrom
Conversation
Member
|
Thanks for fixing this, @hellkite500! One more more down! We should really setup one or more static analysis tools to run in CI and fail the build if there are warnings. I am finding similar issues in https://github.com/NOAA-OWP/evapotranspiration. |
aaraney
approved these changes
Aug 6, 2025
Member
aaraney
left a comment
aaraney
left a comment
There was a problem hiding this comment.
Thanks for fixing this, @hellkite500!
| cfe_bmi_data_ptr->gw_reservoir.coeff_secondary = 0.0; // 0.0 means that secondary outlet is not applied | ||
| cfe_bmi_data_ptr->gw_reservoir.exponent_secondary = 1.0; // linear | ||
|
|
||
| // Not used in gw reservoir |
Member
There was a problem hiding this comment.
Just a comment, nothing to change. We should really move this and a lot of the code that directly precedes this into the init_soil_reservoir function that is called right after this. The initialization code is littered all over the place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure soil and ground water reservoir pointer's (and the forcing_file...) are NULL initialized and properly freed.
Testing