CFE standalone mode with option FORCINGPET

[WanruWu-NOAA]

Following the README.md for Compiling and Running CFE with option FORCINGPET in standalone mode it didn't pass the run . I was wondering if I missed anything and/or how to fix it?

Current behavior

Expected behavior

Steps to replicate behavior (include URLs)

1. git clone https://github.com/NOAA-OWP/cfe.git
2. cd cfe
3. git checkout ajk/sft_aet_giuh_merge
4. mkdir build && cd build
5. cmake ../ -DFORCINGPET=ON
6. make
7. ./run_cfe.sh FORCINGPET
8. Run results and error messages:

CFE running with option FORCINGPET
config file: ./configs/cat_87_bmi_config_cfe_pass.txt ./configs/cat_87_bmi_config_aorc.txt ./configs/cat_87_bmi_config_pet_pass.txt
allocating memory to store entire BMI structure for CFE
allocating memory to store entire BMI structure for AORC
allocating memory to store entire BMI structure for PET
Registering BMI CFE model
Registering BMI AORC model
Registering BMI PET model
Initializeing BMI CFE model
' could not be opened for reading
Initializeing BMI AORC model
AORC config file ./configs/cat_87_bmi_config_aorc.txt
File does not exist.
 Failed in function read_file_line_counts
' could not be opened for readinggs/cat87_01Dec2015.csv
Initializeing BMI PET model
File does not exist.
 Failed in function read_file_line_counts_pet
' could not be opened for reading
Get the information from the configuration here in Main
forcing file for the CFE module BMI
forcing file for the PET module BMI
forcing file for the AORC module ./forcings/cat87_01Dec2015.csv
The model time step size is: 3600.000000
looping through and calling update
#    ,            hourly ,  direct,   giuh ,lateral,  base,   total, storage, ice fraction, ice fraction
Time [h],rainfall [mm],runoff [mm],runoff [mm],flow [mm],flow [mm],discharge [mm],storage [mm],schaake [mm],xinan [-]
./run_cfe.sh: line 38: 88456 Segmentation fault      (core dumped) ./build/${exe_name} $args

Screenshots

[ajkhattak]

@WanruWu-NOAA yeah the README.md needs to be updated. We don't need step #3. You should be able to run with the following instructions. Let me know if you see any issues.

1. git clone https://github.com/NOAA-OWP/cfe.git
2. cd cfe
3. mkdir build && cd build
4. cmake ../ -DFORCINGPET=ON
5. make
6. ./run_cfe.sh FORCINGPET

[WanruWu-NOAA]

@ajkhattak Thanks for looking into this. I've retested the steps, it's making progress (adding some config details) but still similar errors:

[wanru.wu@nwcal-apd-dev1 cfe]$   ./run_cfe.sh FORCINGPET
CFE running with option FORCINGPET
config file: ./configs/cat_87_bmi_config_cfe_pass.txt ./configs/cat_87_bmi_config_aorc.txt ./configs/cat_87_bmi_config_pet_pass.txt
allocating memory to store entire BMI structure for CFE
allocating memory to store entire BMI structure for AORC
allocating memory to store entire BMI structure for PET
Registering BMI CFE model
Registering BMI AORC model
Registering BMI PET model
Initializeing BMI CFE model
Config file details - Line Count: 31 | Max Line Length 43
' | Units: '(null)'m: 'forcing_file' | Value: 'BMI
Config Value - Param: 'soil_params.depth' | Value: '2.0' | Units: 'm'
Config Value - Param: 'soil_params.b' | Value: '4.05' | Units: ''
Config Value - Param: 'soil_params.satdk' | Value: '0.00000338' | Units: 'm s-1'
Config Value - Param: 'soil_params.satpsi' | Value: '0.355' | Units: 'm'
Config Value - Param: 'soil_params.slop' | Value: '0.01' | Units: 'm/m'
Config Value - Param: 'soil_params.smcmax' | Value: '0.439' | Units: 'm/m'
Config Value - Param: 'soil_params.wltsmc' | Value: '0.066' | Units: 'm/m'
Config Value - Param: 'soil_params.expon' | Value: '1.0' | Units: ''
Config Value - Param: 'soil_params.expon_secondary' | Value: '1.0' | Units: ''
Config Value - Param: 'max_gw_storage' | Value: '0.25' | Units: 'm'
Config Value - Param: 'Cgw' | Value: '1.8e-05' | Units: 'm h-1'
Config Value - Param: 'expon' | Value: '6.0' | Units: ''
Config Value - Param: 'gw_storage' | Value: '0.125' | Units: 'm/m'
Config Value - Param: 'alpha_fc' | Value: '0.33' | Units: ''
Config Value - Param: 'soil_storage' | Value: '0.585626' | Units: 'm/m'
Config Value - Param: 'K_nash' | Value: '0.03' | Units: ''
Config Value - Param: 'K_lf' | Value: '0.01' | Units: ''
' | Units: '(null)'m: 'nash_storage' | Value: '0.0,0.0
' | Units: '(null)'m: 'giuh_ordinates' | Value: '0.06,0.51,0.28,0.12,0.03
')und configured GIUH ordinate values ('0.06,0.51,0.28,0.12,0.03
' | Units: '(null)'m: 'num_timesteps' | Value: '1
' | Units: '(null)'m: 'verbosity' | Value: '1
' | Units: '(null)'m: 'surface_partitioning_scheme' | Value: 'Xinanjiang
' | Units: '(null)'m: 'a_Xinanjiang_inflection_point_parameter' | Value: '1
' | Units: '(null)'m: 'b_Xinanjiang_shape_parameter' | Value: '1
' | Units: '(null)'m: 'x_Xinanjiang_shape_parameter' | Value: '1
' | Units: '(null)'m: 'urban_decimal_fraction' | Value: '0.0
' | Units: '(null)'m: '#surface_partitioning_scheme' | Value: 'Schaake
' | Units: '(null)'m: '#ice_fraction' | Value: '1
' | Units: '(null)'m: '#ice_content_threshold' | Value: '0.15
' | Value: '(null)' | Units: '(null)'
All CFE config params present
')UH ordinates string value found in config ('0.06,0.51,0.28,0.12,0.03
Counted number of GIUH ordinates (5)
Finished function parsing CFE config
' could not be opened for reading
Initializeing BMI AORC model
AORC config file ./configs/cat_87_bmi_config_aorc.txt
File does not exist.
 Failed in function read_file_line_counts
' could not be opened for readinggs/cat87_01Dec2015.csv
Initializeing BMI PET model
File does not exist.
 Failed in function read_file_line_counts_pet
' could not be opened for reading
Get the information from the configuration here in Main
forcing file for the CFE module BMI
forcing file for the PET module BMI
forcing file for the AORC module ./forcings/cat87_01Dec2015.csv
The model time step size is: 3600.000000
looping through and calling update
#    ,            hourly ,  direct,   giuh ,lateral,  base,   total, storage, ice fraction, ice fraction
Time [h],rainfall [mm],runoff [mm],runoff [mm],flow [mm],flow [mm],discharge [mm],storage [mm],schaake [mm],xinan [-]
./run_cfe.sh: line 38: 49442 Segmentation fault      (core dumped) ./build/${exe_name} $args

[ajkhattak]

Does not look to me that you are running the default examples. The issue is coming from a missing file.
File does not exist.
Failed in function read_file_line_counts
' could not be opened for readinggs/cat87_01Dec2015.csv
While it should have stopped the execution at that point and let the user know what is happening, anyway, can you please check if this file readinggs/cat87_01Dec2015.csv exists? did you mean readings or readinggs

[WanruWu-NOAA]

I was confused about this error message too - no idea how "readinggs" came from running ./run_cfe.sh FORCINGPET? I did check the file cat87_01Dec2015.csv, which was under directory /forcings/ and directory /original_author_code/ But I couldn't find "readinggs"....

[WanruWu-NOAA]

Finally, the "Download Zip" version CFE works! Although my "git clone" version is still not working, we are good now to move forward. Thanks a lot for your help, Ahmad!

[ajkhattak]

this is a good workaround for you to run cfe. A better option would be to download git to your home directory and check if that will work or not. I am still not sure why your git clone is not working properly.