Observable card generators for pDIS

[Radonirinaunimi]

@toonhasenack, please implement and update here the implementation of the observable cards generator.

PS: Recall that to generate the observable cards you need to be in extra/data and run python -m machinery generate E155/*.

The full list of datasets can be found in NNPDF/nnpdf#1816

[alecandido]

Draft mode is enough for WIP declaration :)

[Radonirinaunimi]

Draft mode is enough for WIP declaration :)

That was the OCD part of me 😅

[felixhekhorn]

@toonhasenack please activate pre-commit on your computer! which would have told you that you committed something broken 🙃 (Unfortunately pydocstyle is currently broken - but that's the only one you're allowed to ignore)

[giacomomagni]

@Radonirinaunimi, since we know the kinematics of the pDIS datasets is correct,
can we merge this?
I've just left a minor comment.

[Radonirinaunimi]

@toonhasenack, you undid the changes done by the hooks when you force-pushed. Could you please make sure to at least pull before pushing in order to avoid these.

[felixhekhorn]

@toonhasenack, you undid the changes done by the hooks when you force-pushed. Could you please make sure to at least pull before pushing in order to avoid these.

or simply do as I say 🙃

[giacomomagni]

@felixhekhorn, @toonhasenack, @Radonirinaunimi are you happy to merge?

[felixhekhorn]

when you believe you're ready, please open an accompanying PR in pinecards (copying the output here) and check that they work well also there; please don't merge here until then

please do this first - I'll test a few of them there

[giacomomagni]

please do this first - I'll test a few of them there

Note that some pinecards have already been merged on master in this PR,
so and I think @toonhasenack is using the updated ones.

[felixhekhorn]

please do this first - I'll test a few of them there

Note that some pinecards have already been merged on master in this PR, so and I think @toonhasenack is using the updated ones.

Well, then I'd say it is even more relevant to fix them also there - I'm looking to the "Files changed"-tab and I don't like what I see

[giacomomagni]

Well, then I'd say it is even more relevant to fix them also there - I'm looking to the "Files changed"-tab and I don't like what I see !

sure before of this dcb59c7 all the metadata were even read at all!!

[Radonirinaunimi]

What is still missing in this PR (so maybe I could take care)?

[giacomomagni]

Green light from my side.

[Radonirinaunimi]

Green light from my side.

How about you @felixhekhorn?

[felixhekhorn]

when you believe you're ready, please open an accompanying PR in pinecards (copying the output here) and check that they work well also there; please don't merge here until then

please do this first - I'll test a few of them there

I have the vague feeling I'm repeating myself ... 🙃

[giacomomagni]

Here is the associated PR in pinecards: NNPDF/pinecards#181

[giacomomagni]

I think we should be able to merge. Do you have further comments @felixhekhorn ?