Conversation
pineapple == 1.1.0pineappl == 1.1.0
pineappl == 1.1.0pineappl >= 1.0
|
Let's try to merge this! but there are still issues:
help would be appreciated @giacomomagni @Radonirinaunimi 😇 EDIT: PS: the local |
|
Thanks a lot @felixhekhorn for this!
This is always a problem with compiled extensions and dynamically generated modules. PyO3 doesn't generate static files but compiled libraries. The problem is that The solutions are basically:
For the sake of not delaying this PR, perhaps we can live with the first option for the time being and implement the correct fix soon later. |
This reverts commit 3cd4325.
you're right of course - stupid me; done in 4d7c8c3 pylint still correctly complaints about vrap |
|
Apologies, I haven't had the chance to look into this yet (last week was very hectic). I will try to do so either later today or tomorrow. |
Radonirinaunimi
left a comment
There was a problem hiding this comment.
This could be merged so that people could consistently produce grids/fks from this. I would address the Cyclic in another PR (as main is plagued with same warnings anyway).
| tmp_grid.write(tmp_output) | ||
| # Now merge it into the main grid! | ||
| main_grid.merge_from_file(tmp_output) | ||
| main_grid.merge(tmp_grid) |
There was a problem hiding this comment.
@Radonirinaunimi actually, I just noticed this change: I guess line 195 is no longer needed and so is line 190? (i.e. temporarily writing to disk)
This PR aims to update the integrability and positivity scripts to be compatible with pineappl v 1.0.