Pass evolution + backwards method internally via int#395
Merged
felixhekhorn merged 9 commits intomasterfrom Jul 24, 2024
Merged
Pass evolution + backwards method internally via int#395felixhekhorn merged 9 commits intomasterfrom
felixhekhorn merged 9 commits intomasterfrom
Conversation
felixhekhorn
requested review from
giacomomagni and
niclaurenti
and removed request for
giacomomagni
felixhekhorn
commented
Jul 19, 2024
Collaborator
giacomomagni
left a comment
giacomomagni
left a comment
There was a problem hiding this comment.
LGTM, I left some small comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SV mode is cast to integer internally - we should do the same for evolution and backwards instead of using strings. We know this is better, meaning faster, for numba as numba prefers integer over strings (for obvious reasons). This also makes it trivial for #383 to pass it through rust as is proven by #394 .
This is a purely internal change and the outside, i.e. op cards, is unaffected.
This is touching the core of eko so a solid review is appreciated; explicitly this interacts with QED, N3LO and backwards