Pipeline fixes#93
Open
LourensVeen wants to merge 5 commits intoNLeSC:masterfrom
LourensVeen:pipeline-fixes
Open
Pipeline fixes#93LourensVeen wants to merge 5 commits intoNLeSC:masterfrom LourensVeen:pipeline-fixes
LourensVeen wants to merge 5 commits intoNLeSC:masterfrom
LourensVeen:pipeline-fixes
Conversation
Member
Author
|
No more map(), got it :-). |
Member
Author
|
Improved documentation while we're at it. The terminology still isn't completely clear to me, is there a difference between a task and a module? |
Collaborator
|
"module" should have been "task". |
Member
Author
|
Do you want to change it, or leave the API as is? Or accept both? |
Collaborator
|
Let's change it but accept the old format as well. We can emit a warning if users use the old format. |
Member
Author
|
Added a patch to now use "task", but also accept "module" and emit a warning in that case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is a bit more scary than my previous contributions. Commit 511c1b4 mostly rewrites pipeline(). As far as I can tell the original is actually correct, but determining that was not so easy. The new version should be doing the exact same thing, but is more obviously correct. It passes the unit tests, but is otherwise untested. Please review carefully.